Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1625433002: Missing m_failedParsing=true for unresolved namespace. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Missing m_failedParsing=true for unresolved namespace. When we already have an accepted compound and we return nullptr for a second fully consumed compound, we were relying on non-consumed tokens like trailing spaces to detect that the selector was invalid. Setting m_failedParsing=true fixed it. R=timloh@chromium.org BUG=580496 Committed: https://crrev.com/08f8ffe9473bde700b1d9c54caa313c0ec1a840b Cr-Commit-Position: refs/heads/master@{#371202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 11 months ago (2016-01-22 11:39:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625433002/1
4 years, 11 months ago (2016-01-22 11:39:49 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 12:50:20 UTC) #5
Timothy Loh
lgtm
4 years, 11 months ago (2016-01-25 00:02:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625433002/1
4 years, 11 months ago (2016-01-25 06:33:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-25 07:43:54 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 07:44:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08f8ffe9473bde700b1d9c54caa313c0ec1a840b
Cr-Commit-Position: refs/heads/master@{#371202}

Powered by Google App Engine
This is Rietveld 408576698