Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1625413002: Remove defunct Timer::alignedFireTime. (Closed)

Created:
4 years, 11 months ago by dominicc (has gone to gerrit)
Modified:
4 years, 11 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove defunct Timer::alignedFireTime. Tiny bit of cleanup: Some timers used to be 'snapped' to an 'aligned' fire time so that work would get batched, particularly when suspended timers were rescheduled. This sort of thing is now the responsibility of the scheduler; nobody is using Timer::alignedFireTime any more. Because alignedFireTime had no tests :O no tests were harmed in the preparation of this changelist. :D BUG=331912 Committed: https://crrev.com/78f61359d847fababe935177310d683bfa4eec9b Cr-Commit-Position: refs/heads/master@{#371775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/Timer.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dominicc (has gone to gerrit)
PTAL
4 years, 11 months ago (2016-01-26 00:43:23 UTC) #2
Ian Vollick
On 2016/01/26 00:43:23, (out until Jan 5) dominicc wrote: > PTAL lgtm.
4 years, 11 months ago (2016-01-26 22:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625413002/1
4 years, 11 months ago (2016-01-27 08:21:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 11:52:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 11:54:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78f61359d847fababe935177310d683bfa4eec9b
Cr-Commit-Position: refs/heads/master@{#371775}

Powered by Google App Engine
This is Rietveld 408576698