Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 16254009: Revert "Increase omnibox size by 2 px. Increase nominal font size in omnibox to 16 px." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 306 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 // Returns the height of the control without the top and bottom 317 // Returns the height of the control without the top and bottom
318 // edges(i.e. the height of the edit control inside). If 318 // edges(i.e. the height of the edit control inside). If
319 // |use_preferred_size| is true this will be the preferred height, 319 // |use_preferred_size| is true this will be the preferred height,
320 // otherwise it will be the current height. 320 // otherwise it will be the current height.
321 int GetInternalHeight(bool use_preferred_size); 321 int GetInternalHeight(bool use_preferred_size);
322 322
323 // Space between items in the location bar, as well as between items and the 323 // Space between items in the location bar, as well as between items and the
324 // edges. 324 // edges.
325 static int GetItemPadding(); 325 static int GetItemPadding();
326 326
327 // Thickness of the edges of the omnibox background images, in normal mode. 327 // Thickness of the left and right edges of the omnibox, in normal mode.
328 static const int kNormalEdgeThickness; 328 static const int kNormalHorizontalEdgeThickness;
329 // The same, but for popup mode. 329 // The same, but for popup mode.
330 static const int kPopupEdgeThickness; 330 static const int kPopupEdgeThickness;
331 // Thickness of the top and bottom edges of the omnibox.
332 static const int kNormalVerticalEdgeThickness;
331 // Amount of padding built into the standard omnibox icons. 333 // Amount of padding built into the standard omnibox icons.
332 static const int kIconInternalPadding; 334 static const int kIconInternalPadding;
333 // Space between the edge and a bubble. 335 // Space between the edge and a bubble.
334 static const int kBubblePadding; 336 static const int kBubblePadding;
335 337
336 protected: 338 protected:
337 virtual void OnFocus() OVERRIDE; 339 virtual void OnFocus() OVERRIDE;
338 340
339 private: 341 private:
340 typedef std::vector<ContentSettingImageView*> ContentSettingViews; 342 typedef std::vector<ContentSettingImageView*> ContentSettingViews;
341 343
342 friend class PageActionImageView; 344 friend class PageActionImageView;
343 friend class PageActionWithBadgeView; 345 friend class PageActionWithBadgeView;
344 typedef std::vector<PageActionWithBadgeView*> PageActionViews; 346 typedef std::vector<PageActionWithBadgeView*> PageActionViews;
345 347
346 // Returns the thickness of any visible left and right edge, in pixels. 348 // Returns the thickness of any visible left and right edge, in pixels.
347 int GetHorizontalEdgeThickness() const; 349 int GetHorizontalEdgeThickness() const;
348 350
349 // The same, but for the top and bottom edges. 351 // The same, but for the top and bottom edges.
350 int vertical_edge_thickness() const { 352 int vertical_edge_thickness() const {
351 return is_popup_mode_ ? kPopupEdgeThickness : kNormalEdgeThickness; 353 return is_popup_mode_ ? kPopupEdgeThickness : kNormalVerticalEdgeThickness;
352 } 354 }
353 355
354 // Update the visibility state of the Content Blocked icons to reflect what is 356 // Update the visibility state of the Content Blocked icons to reflect what is
355 // actually blocked on the current page. 357 // actually blocked on the current page.
356 void RefreshContentSettingViews(); 358 void RefreshContentSettingViews();
357 359
358 // Delete all page action views that we have created. 360 // Delete all page action views that we have created.
359 void DeletePageActionViews(); 361 void DeletePageActionViews();
360 362
361 // Update the views for the Page Actions, to reflect state changes for 363 // Update the views for the Page Actions, to reflect state changes for
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 // entered or selected. 416 // entered or selected.
415 string16 location_input_; 417 string16 location_input_;
416 418
417 // The user's desired disposition for how their input should be opened 419 // The user's desired disposition for how their input should be opened
418 WindowOpenDisposition disposition_; 420 WindowOpenDisposition disposition_;
419 421
420 // The transition type to use for the navigation 422 // The transition type to use for the navigation
421 content::PageTransition transition_; 423 content::PageTransition transition_;
422 424
423 // An object used to paint the normal-mode background. 425 // An object used to paint the normal-mode background.
424 scoped_ptr<views::Painter> background_border_painter_; 426 scoped_ptr<views::Painter> background_painter_;
425 scoped_ptr<views::Painter> background_filling_painter_;
426 427
427 // An icon to the left of the edit field. 428 // An icon to the left of the edit field.
428 LocationIconView* location_icon_view_; 429 LocationIconView* location_icon_view_;
429 430
430 // A bubble displayed for EV HTTPS sites. 431 // A bubble displayed for EV HTTPS sites.
431 EVBubbleView* ev_bubble_view_; 432 EVBubbleView* ev_bubble_view_;
432 433
433 // Location_entry view 434 // Location_entry view
434 views::View* location_entry_view_; 435 views::View* location_entry_view_;
435 436
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 // in the right location. 506 // in the right location.
506 int animation_offset_; 507 int animation_offset_;
507 508
508 // Used to register for notifications received by NotificationObserver. 509 // Used to register for notifications received by NotificationObserver.
509 content::NotificationRegistrar registrar_; 510 content::NotificationRegistrar registrar_;
510 511
511 DISALLOW_COPY_AND_ASSIGN(LocationBarView); 512 DISALLOW_COPY_AND_ASSIGN(LocationBarView);
512 }; 513 };
513 514
514 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 515 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698