Revert "Increase omnibox size by 2 px. Increase nominal font size in omnibox to 16 px."

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 128 matching lines @@
 #endif
 
     if (((*font_y_offset >= 0) &&
          ((*font_y_offset + font->GetHeight()) <= height)) ||
         (font->GetFontSize() <= 1))
       return;
     *font = font->DeriveFont(-1);
   }
 }
 
+// Height of the location bar's round corner region.
+const int kBorderRoundCornerHeight = 5;
+// Width of location bar's round corner region.
+const int kBorderRoundCornerWidth = 4;
+// Radius of the round corners inside the location bar.
+const int kBorderCornerRadius = 2;
+
 }  // namespace
 
 
 // LocationBarView -----------------------------------------------------------
 
 // static
-const int LocationBarView::kNormalEdgeThickness = 2;
+const int LocationBarView::kNormalHorizontalEdgeThickness = 2;
 const int LocationBarView::kPopupEdgeThickness = 1;
+const int LocationBarView::kNormalVerticalEdgeThickness = 3;
 const int LocationBarView::kIconInternalPadding = 2;
 const int LocationBarView::kBubblePadding = 1;
 const char LocationBarView::kViewClassName[] = "LocationBarView";
 
 LocationBarView::LocationBarView(Browser* browser,
                                  Profile* profile,
                                  CommandUpdater* command_updater,
                                  ToolbarModel* model,
                                  Delegate* delegate,
                                  bool is_popup_mode)
@@ skipping 20 matching lines @@
       script_bubble_icon_view_(NULL),
       star_view_(NULL),
       action_box_button_view_(NULL),
       is_popup_mode_(is_popup_mode),
       show_focus_rect_(false),
       template_url_service_(NULL),
       animation_offset_(0) {
   if (!views::Textfield::IsViewsTextfieldEnabled())
     set_id(VIEW_ID_OMNIBOX);
 
-  const int kOmniboxBorderImages[] = IMAGE_GRID(IDR_OMNIBOX_BORDER);
-  const int kOmniboxPopupImages[] = IMAGE_GRID(IDR_OMNIBOX_POPUP_BORDER);
-  background_border_painter_.reset(
-      views::Painter::CreateImageGridPainter(
-          is_popup_mode_ ? kOmniboxPopupImages : kOmniboxBorderImages));
-#if defined(OS_CHROMEOS)
-  if (!is_popup_mode_) {
-    const int kOmniboxFillingImages[] = IMAGE_GRID(IDR_OMNIBOX_FILLING);
-    background_filling_painter_.reset(
-        views::Painter::CreateImageGridPainter(kOmniboxFillingImages));
-  }
-#endif
+  const int kOmniboxPopupImages[] = {
+    IDR_OMNIBOX_POPUP_BORDER_EDGE,
+    IDR_OMNIBOX_POPUP_BORDER_CENTER,
+    IDR_OMNIBOX_POPUP_BORDER_EDGE,
+  };
+  background_painter_.reset(
+      is_popup_mode_ ?
+      new views::HorizontalPainter(kOmniboxPopupImages) :
+      views::Painter::CreateImagePainter(
+          *ui::ResourceBundle::GetSharedInstance().GetImageNamed(
+              IDR_OMNIBOX_BORDER).ToImageSkia(),
+          gfx::Insets(kBorderRoundCornerHeight, kBorderRoundCornerWidth,
+                      kBorderRoundCornerHeight, kBorderRoundCornerWidth)));
 
   edit_bookmarks_enabled_.Init(
       prefs::kEditBookmarksEnabled,
       profile_->GetPrefs(),
       base::Bind(&LocationBarView::Update,
                  base::Unretained(this),
                  static_cast<content::WebContents*>(NULL)));
 
   if (browser_)
     browser_->toolbar_model()->SetSupportsExtractionOfURLLikeSearchTerms(true);
@@ skipping 449 matching lines @@
   else
     set_focusable(focusable);
 }
 
 bool LocationBarView::IsLocationEntryFocusableInRootView() const {
   OmniboxViewViews* omnibox_views = GetOmniboxViewViews(location_entry_.get());
   return omnibox_views ? omnibox_views->IsFocusable() : View::IsFocusable();
 }
 
 gfx::Size LocationBarView::GetPreferredSize() {
-  return background_border_painter_->GetMinimumSize();
+  return background_painter_->GetMinimumSize();
 }
 
 void LocationBarView::Layout() {
   if (!location_entry_.get())
     return;
 
   // TODO(jhawkins): Remove once crbug.com/101994 is fixed.
   CHECK(location_icon_view_);
 
   selected_keyword_view_->SetVisible(false);
@@ skipping 236 matching lines @@
         std::min(width, entry_width),
         ime_inline_autocomplete_view_->GetPreferredSize().height());
   }
 
   location_entry_view_->SetBoundsRect(location_bounds);
 }
 
 void LocationBarView::OnPaint(gfx::Canvas* canvas) {
   View::OnPaint(canvas);
 
-  // Fill the location bar background color behind the border.  Parts of the
-  // border images are meant to rest atop the toolbar background and parts atop
-  // the omnibox background, so we can't just blindly fill our entire bounds.
-  const int horizontal_edge_thickness = GetHorizontalEdgeThickness();
-  if (!background_filling_painter_) {
-    gfx::Rect bounds(GetContentsBounds());
-    bounds.Inset(horizontal_edge_thickness, vertical_edge_thickness());
-    SkColor color(GetColor(ToolbarModel::NONE, BACKGROUND));
-    if (is_popup_mode_) {
-      canvas->FillRect(bounds, color);
-    } else {
-      SkPaint paint;
-      paint.setStyle(SkPaint::kFill_Style);
-      paint.setColor(color);
-      const int kBorderCornerRadius = 2;
-      canvas->DrawRoundRect(bounds, kBorderCornerRadius, paint);
-    }
-  }
-
   // Maximized popup windows don't draw the horizontal edges.  We implement this
   // by simply expanding the paint area outside the view by the edge thickness.
+  const int horizontal_edge_thickness = GetHorizontalEdgeThickness();
   gfx::Rect background_rect(GetContentsBounds());
   if (is_popup_mode_ && (horizontal_edge_thickness == 0))
     background_rect.Inset(-kPopupEdgeThickness, 0);
-  views::Painter::PaintPainterAt(canvas, background_border_painter_.get(),
+  views::Painter::PaintPainterAt(canvas, background_painter_.get(),
                                  background_rect);
-  if (background_filling_painter_)
-    background_filling_painter_->Paint(canvas, size());
 
-  if (!is_popup_mode_)
+  // Draw the background color so that the graphical elements at the edges
+  // appear over the correct color.  (The edit draws its own background, so this
+  // isn't important for that.)
+  // TODO(pkasting): We need images that are transparent in the middle, so we
+  // can draw the border images over the background color instead of the
+  // reverse; this antialiases better (see comments in
+  // OmniboxPopupContentsView::OnPaint()).
+  gfx::Rect bounds(GetContentsBounds());
+  bounds.Inset(horizontal_edge_thickness, vertical_edge_thickness());
+  SkColor color(GetColor(ToolbarModel::NONE, BACKGROUND));
+  if (is_popup_mode_) {
+    canvas->FillRect(bounds, color);
+  } else {
+    SkPaint paint;
+    paint.setStyle(SkPaint::kFill_Style);
+    paint.setAntiAlias(true);
+    // TODO(jamescook): Make the corners of the dropdown match the corners of
+    // the omnibox.
+    // Paint the actual background color.
+    paint.setColor(color);
+    canvas->DrawRoundRect(bounds, kBorderCornerRadius, paint);
     PaintPageActionBackgrounds(canvas);
+  }
 
   // For non-InstantExtendedAPI cases, if necessary, show focus rect.
   // Note: |Canvas::DrawFocusRect| paints a dashed rect with gray color.
   if (show_focus_rect_ && HasFocus()) {
     gfx::Rect r = location_entry_view_->bounds();
     // TODO(jamescook): Is this still needed?
     r.Inset(-1, 0);
 #if defined(OS_WIN)
     r.Inset(0, -1);
 #endif
@@ skipping 132 matching lines @@
 
 InstantController* LocationBarView::GetInstant() {
   return delegate_->GetInstant();
 }
 
 WebContents* LocationBarView::GetWebContents() const {
   return delegate_->GetWebContents();
 }
 
 int LocationBarView::GetHorizontalEdgeThickness() const {
+  if (!is_popup_mode_)
+    return kNormalHorizontalEdgeThickness;
+
   // In maximized popup mode, there isn't any edge.
-  return (is_popup_mode_ && browser_ && browser_->window() &&
-      browser_->window()->IsMaximized()) ? 0 : vertical_edge_thickness();
+  return (browser_ && browser_->window() && browser_->window()->IsMaximized()) ?
+      0 : kPopupEdgeThickness;
 }
 
 void LocationBarView::RefreshContentSettingViews() {
   for (ContentSettingViews::const_iterator i(content_setting_views_.begin());
        i != content_setting_views_.end(); ++i) {
     (*i)->Update(model_->GetInputInProgress() ? NULL : GetWebContents());
   }
 }
 
 void LocationBarView::DeletePageActionViews() {
@@ skipping 402 matching lines @@
 int LocationBarView::GetInternalHeight(bool use_preferred_size) {
   int total_height =
       use_preferred_size ? GetPreferredSize().height() : height();
   return std::max(total_height - (vertical_edge_thickness() * 2), 0);
 }
 
 bool LocationBarView::HasValidSuggestText() const {
   return suggested_text_view_->visible() &&
       !suggested_text_view_->size().IsEmpty();
 }