Clean up the gyp build of standalone dart executable on Android.

Clean up the gyp build of standalone dart executable on Android.

BUG=
R=iposva@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23531

[Søren Gjesse, 2013-06-03 07:07:33]

lgtm

[Ivan Posva, 2013-06-03 07:32:09]

LGTM

Thanks,
-Ivan

https://codereview.chromium.org/16254005/diff/1/runtime/bin/io_impl_sources.gypi
File runtime/bin/io_impl_sources.gypi (right):

https://codereview.chromium.org/16254005/diff/1/runtime/bin/io_impl_sources.g...
runtime/bin/io_impl_sources.gypi:59: 'sources!' : [
To me this reads as if the below sources are always excluded, which I know they
are not. This has to do with the indentation.

How about:

'conditions' : [
..[ 'dart_io_support==1', {
....'sources!' : [
......'filter_unsupported.cc',
......'secure_socket_unsupported.cc',
....],
..},{
....'sources!': [
......'filter.cc',
....],
..}],
}

Maybe even add a comment marking the start of the "else" from the condition.

[Bill Hesse, 2013-06-03 09:19:43]

Committed patchset #2 manually as r23531 (presubmit successful).

[Bill Hesse, 2013-06-03 09:20:41]

https://codereview.chromium.org/16254005/diff/1/runtime/bin/io_impl_sources.gypi
File runtime/bin/io_impl_sources.gypi (right):

https://codereview.chromium.org/16254005/diff/1/runtime/bin/io_impl_sources.g...
runtime/bin/io_impl_sources.gypi:59: 'sources!' : [
On 2013/06/03 07:32:09, Ivan Posva wrote:
> To me this reads as if the below sources are always excluded, which I know
they
> are not. This has to do with the indentation.
> 
> How about:
> 
> 'conditions' : [
> ..[ 'dart_io_support==1', {
> ....'sources!' : [
> ......'filter_unsupported.cc',
> ......'secure_socket_unsupported.cc',
> ....],
> ..},{
> ....'sources!': [
> ......'filter.cc',
> ....],
> ..}],
> }
> 
> Maybe even add a comment marking the start of the "else" from the condition.

Done.