Issue 1625273003: Don't add sources to DartSdk contexts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1625273003: Don't add sources to DartSdk contexts. (Closed)

Created:
4 years, 11 months ago by scheglov

Modified:
4 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -27 lines)			Patch
M	pkg/analysis_server/test/domain_diagnostic_test.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/mock_sdk.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/sdk_io.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	pkg/analyzer/test/src/context/mock_sdk.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	pkg/analyzer/test/src/mock_sdk.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

Other than the fact that there are too many mock SDK's :-), LGTM.

4 years, 11 months ago (2016-01-24 23:00:44 UTC) #2

scheglov

4 years, 11 months ago (2016-01-24 23:49:23 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
205a2a9c2808d559237e4df8e143e9e86260a109 (presubmit successful).