Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 16252006: Refactor BlockDifference() to use MediaInitializer(). (Closed)

Created:
7 years, 6 months ago by DaleCurtis
Modified:
7 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Refactor BlockDifference() to use MediaInitializer(). BUG=224662 TEST=compiles. unit tests.

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix android. Cleanup checks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -23 lines) Patch
M media/base/media.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M media/media.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M media/video/capture/screen/differ_block.h View 1 chunk +13 lines, -6 lines 0 comments Download
M media/video/capture/screen/differ_block.cc View 1 2 2 chunks +19 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
DaleCurtis
7 years, 6 months ago (2013-06-04 23:31:31 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 6 months ago (2013-06-05 00:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/16252006/4001
7 years, 6 months ago (2013-06-05 18:51:47 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 6 months ago (2013-06-05 20:01:06 UTC) #4
DaleCurtis
PTAL. Needed a .gyp change to add a define since the conditions for screen capture ...
7 years, 6 months ago (2013-06-05 20:25:16 UTC) #5
scherkus (not reviewing)
lgtm
7 years, 6 months ago (2013-06-05 20:37:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/16252006/19001
7 years, 6 months ago (2013-06-05 20:40:44 UTC) #7
DaleCurtis
Abandoned since https://codereview.chromium.org/15692018/ deletes this code.
7 years, 6 months ago (2013-06-06 00:00:29 UTC) #8
Sergey Ulanov
I suspect this may break chromoting host because it never calls InitializeMediaLibrary(). In either case ...
7 years, 6 months ago (2013-06-06 00:00:48 UTC) #9
DaleCurtis
7 years, 6 months ago (2013-06-06 00:01:56 UTC) #10
Message was sent while issue was closed.
chromoting host calls it now: https://chromiumcodereview.appspot.com/15713012

Powered by Google App Engine
This is Rietveld 408576698