Issue 162493003: Remove OnConfigNegotiated from QuicConnectionVisiterInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 162493003: Remove OnConfigNegotiated from QuicConnectionVisiterInterface. (Closed)

Created:
6 years, 10 months ago by wtc

Modified:
6 years, 10 months ago

Reviewers:
ramant (doing other things), Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove OnConfigNegotiated from QuicConnectionVisiterInterface. QuicConnection never calls visitor_->OnConfigNegotiated. OnConfigNegotiated is only called by QuicCryptoStream on QuicSession. Merge internal CL: 61467714 Remove the unused server_config_id_ member from QuicCryptoClientConfig::CachedState. Merge internal CL: 61394953 R=rch@chromium.org,rtenneti@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251204

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -9 lines)			Patch
M	net/quic/crypto/quic_crypto_client_config.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_connection.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_session.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_session.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/162493003/1

6 years, 10 months ago (2014-02-13 17:48:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/162493003/1

6 years, 10 months ago (2014-02-13 19:53:25 UTC) #6

Message was sent while issue was closed.

Change committed as 251204

Expand Messages | Collapse Messages