Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1624853005: SafeBrowsing UMA: Adds an inconsistent threat type histogram bucket. (Closed)

Created:
4 years, 11 months ago by kcarattini
Modified:
4 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SafeBrowsing UMA: Adds an inconsistent threat type histogram bucket. BUG=561867 Committed: https://crrev.com/070dc15030f0c67dd3a929dd7e05b0bccb96041c Cr-Commit-Position: refs/heads/master@{#371959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/safe_browsing/protocol_manager.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kcarattini
4 years, 11 months ago (2016-01-25 02:49:55 UTC) #2
Nathan Parker
lgtm
4 years, 11 months ago (2016-01-26 16:09:50 UTC) #3
kcarattini
Thanks, Nathan. holte@ please review histograms.xml Kendra
4 years, 11 months ago (2016-01-27 00:38:09 UTC) #4
Steven Holte
lgtm
4 years, 11 months ago (2016-01-27 23:32:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624853005/1
4 years, 11 months ago (2016-01-28 00:21:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-28 01:59:46 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:05:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/070dc15030f0c67dd3a929dd7e05b0bccb96041c
Cr-Commit-Position: refs/heads/master@{#371959}

Powered by Google App Engine
This is Rietveld 408576698