Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1624853002: Store the result of type inference in summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+613 lines, -97 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 23 chunks +126 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 8 chunks +26 lines, -8 lines 2 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 6 chunks +25 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 6 chunks +44 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/prelinker_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 16 chunks +67 lines, -63 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_ast_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_elements_strong_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summarize_elements_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 10 chunks +276 lines, -1 line 0 comments Download
M pkg/analyzer/tool/summary/build_sdk_summary.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 3 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-23 16:01:18 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1624853002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1624853002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode570 pkg/analyzer/lib/src/summary/resynthesize.dart:570: {bool isSetter: false}) { Why not use `serializedExecutable.kind ...
4 years, 11 months ago (2016-01-23 18:00:54 UTC) #3
Paul Berry
https://codereview.chromium.org/1624853002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart File pkg/analyzer/lib/src/summary/resynthesize.dart (right): https://codereview.chromium.org/1624853002/diff/1/pkg/analyzer/lib/src/summary/resynthesize.dart#newcode570 pkg/analyzer/lib/src/summary/resynthesize.dart:570: {bool isSetter: false}) { On 2016/01/23 18:00:54, scheglov wrote: ...
4 years, 11 months ago (2016-01-25 12:59:42 UTC) #4
Paul Berry
4 years, 11 months ago (2016-01-25 13:04:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e97db5219cb1e4835e5a91e3144d4ad0e25df798 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698