Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 1624803002: Don't allow pre-MD pre-Win 10 tabstrips to overlap the toolbar corner on glass. (Closed)

Created:
4 years, 11 months ago by Peter Kasting
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow pre-MD pre-Win 10 tabstrips to overlap the toolbar corner on glass. This is basically a limited revert of an intentional behavior change. We still keep the new behavior in all the cases where it was beneficial. BUG=580757 TEST=Launch Chrome on Windows 7 with no themes and with --force-device-scale-factor=2. Ensure the tabstrip left edge doesn't look glitchily drawn atop the toolbar's rounded left corner. Committed: https://crrev.com/5383b5d07fb0e418f13907874d801662e9668733 Cr-Commit-Position: refs/heads/master@{#371429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
4 years, 11 months ago (2016-01-23 03:08:39 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-25 16:09:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624803002/1
4 years, 11 months ago (2016-01-26 01:50:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 02:38:15 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 02:39:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5383b5d07fb0e418f13907874d801662e9668733
Cr-Commit-Position: refs/heads/master@{#371429}

Powered by Google App Engine
This is Rietveld 408576698