third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp - Issue 1624783002: DevTools: Switch to using fast stack iterator to collect stacks during timeline recording.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp

Issue 1624783002: DevTools: Switch to using fast stack iterator to collect stacks during timeline recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp b/third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp

index 43fac2a78dc5d3baa204b2da2c113f92cf3d3a4c..4bec159b911138e3891e44be029c21f2f2ab41dc 100644

--- a/third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp

+++ b/third_party/WebKit/Source/modules/websockets/InspectorWebSocketEvents.cpp

@@ -18,7 +18,7 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorWebSocketCreateEvent::

value->setString("frame", toHexString(document->frame()));

if (!protocol.isNull())

value->setString("webSocketProtocol", protocol);

- setCallStack(value.get());

+ requestCallStackSample();

return value.release();

}

@@ -27,7 +27,7 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorWebSocketEvent::data(D

RefPtr<TracedValue> value = TracedValue::create();

value->setInteger("identifier", identifier);

value->setString("frame", toHexString(document->frame()));

- setCallStack(value.get());

+ requestCallStackSample();

return value.release();

}