third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h - Issue 1624783002: DevTools: Switch to using fast stack iterator to collect stacks during timeline recording.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h

Issue 1624783002: DevTools: Switch to using fast stack iterator to collect stacks during timeline recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/tracing/timeline-timer-expected.txt ('K') | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-timer-expected.txt ('k') | third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h

index 5a27fd6298f93d5da12f3a4d69077e509f7fb05e..c9c59cdefa09e1e0e6b01ba8e414c4370ed27940 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h

@@ -326,7 +326,7 @@ PassRefPtr<TraceEvent::ConvertableToTraceFormat> endData(const HitTestRequest&,

}

CORE_EXPORT String toHexString(const void* p);

-CORE_EXPORT void setCallStack(TracedValue*);

+CORE_EXPORT void requestCallStackSample();

} // namespace blink