third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-reason.html - Issue 1624783002: DevTools: Switch to using fast stack iterator to collect stacks during timeline recording.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-reason.html

Issue 1624783002: DevTools: Switch to using fast stack iterator to collect stacks during timeline recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js ('K') | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt » ('j') | third_party/WebKit/LayoutTests/inspector/tracing/timeline-mark-timeline-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-reason.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-reason.html b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-reason.html

index 66b0c55e6c66def16d5de3dda1d008f8338dd8e1..8221d720cdae59f5e2f23d771058fd7c84eede79 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-reason.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout-reason.html

@@ -31,8 +31,8 @@ function test()

function onTimelineRecorded()

{

var layoutRecord = InspectorTest.findFirstTimelineRecord("Layout");

- InspectorTest.addResult("layout invalidated: " + layoutRecord.traceEvent().initiator.args["data"]["stackTrace"][0].functionName);

- InspectorTest.addResult("layout forced: " + layoutRecord.traceEvent().args["beginData"]["stackTrace"][0].functionName);

+ InspectorTest.addResult("layout invalidated: " + WebInspector.TimelineUIUtils.getTopUserFrame(layoutRecord.traceEvent().initiator).functionName);

+ InspectorTest.addResult("layout forced: " + WebInspector.TimelineUIUtils.getTopUserFrame(layoutRecord.traceEvent()).functionName);

InspectorTest.completeTest();

}