DevTools: Switch to using fast stack iterator to collect stacks during timeline recording.

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 198 matching lines @@
         return true;
     case recordTypes.MarkDOMContent:
     case recordTypes.MarkLoad:
         return event.args["data"]["isMainFrame"];
     default:
         return false;
     }
 }
 
 /**
+ * @param {!ConsoleAgent.CallFrame} frame
+ * @return {boolean}
+ */
+WebInspector.TimelineUIUtils.isUserFrame = function(frame)
+{
+    if (frame.url.startsWith("native "))
+        return false;
+    if (!frame.url && frame.scriptId === "0")
+        return false;
+    return true;
+}
+
+/**
+ * @param {!WebInspector.TracingModel.Event} event
+ * @return {?ConsoleAgent.CallFrame}
+ */
+WebInspector.TimelineUIUtils.topUserFrame = function(event)

[caseq, 2016/01/27 23:03:56]

is this still necessary?

[alph, 2016/01/27 23:16:20]

Acknowledged.

+{
+    var stackTrace = event.stackTrace || event.initiator && event.initiator.stackTrace;
+    return stackTrace && stackTrace.find(WebInspector.TimelineUIUtils.isUserFrame) || null;
+}
+
+/**
  * @enum {symbol}
  */
 WebInspector.TimelineUIUtils.NetworkCategory = {
     HTML: Symbol("HTML"),
     Script: Symbol("Script"),
     Style: Symbol("Style"),
     Media: Symbol("Media"),
     Other: Symbol("Other")
 }
 
@@ skipping 147 matching lines @@
             return null;
         var uiLocation = WebInspector.debuggerWorkspaceBinding.rawLocationToUILocation(rawLocation);
         return uiLocation.linkText();
     }
 
     /**
      * @return {?string}
      */
     function linkifyTopCallFrameAsText()
     {
-        var stackTrace = event.stackTrace;
-        if (!stackTrace) {
-            var initiator = event.initiator;
-            if (initiator)
-                stackTrace = initiator.stackTrace;
-        }
-        if (!stackTrace || !stackTrace.length)
-            return null;
-        var callFrame = stackTrace[0];
-        return linkifyLocationAsText(callFrame.scriptId, callFrame.lineNumber, callFrame.columnNumber);
+        var frame = WebInspector.TimelineUIUtils.topUserFrame(event);
+        return frame ? linkifyLocationAsText(frame.scriptId, frame.lineNumber, frame.columnNumber) : null;
     }
 }
 
 /**
  * @param {!WebInspector.TracingModel.Event} event
  * @param {?WebInspector.Target} target
  * @param {!WebInspector.Linkifier} linkifier
  * @return {?Node}
  */
 WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, target, linkifier)
@@ skipping 74 matching lines @@
         if (columnNumber)
             --columnNumber;
         return linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber - 1, columnNumber, "timeline-details");
     }
 
     /**
      * @return {?Element}
      */
     function linkifyTopCallFrame()
     {
-        var stackTrace = event.stackTrace;
-        if (!stackTrace) {
-            var initiator = event.initiator;
-            if (initiator)
-                stackTrace = initiator.stackTrace;
-        }
-        if (!stackTrace || !stackTrace.length)
-            return null;
-        return linkifier.linkifyConsoleCallFrame(target, stackTrace[0], "timeline-details");
+        var frame = WebInspector.TimelineUIUtils.topUserFrame(event);
+        return frame ? linkifier.linkifyConsoleCallFrame(target, frame, "timeline-details") : null;
     }
 }
 
 /**
  * @param {!WebInspector.TracingModel.Event} event
  * @param {!WebInspector.TimelineModel} model
  * @param {!WebInspector.Linkifier} linkifier
  * @param {boolean} detailed
  * @param {function(!DocumentFragment)} callback
  */
@@ skipping 1502 matching lines @@
     case warnings.V8Deopt:
         span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/GoogleChrome/devtools-docs/issues/53",
             WebInspector.UIString("Not optimized"), undefined, true));
         span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReason"]));
         break;
     default:
         console.assert(false, "Unhandled TimelineModel.WarningType");
     }
     return span;
 }