Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1624763002:
Enable testDefaultViewportSize. (Closed)
|
Created:
4 years, 11 months ago by aelias_OOO_until_Jul13 Modified:
4 years, 11 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable testDefaultViewportSize.
This test passes as is. It was disabled due to a temporary regression
that cleared up a long time ago.
BUG=580744
Committed: https://crrev.com/f7bf6ca8d00fa950422bf8c4d4ecf2c6d05bb547
Cr-Commit-Position: refs/heads/master@{#371449}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
Description was changed from ========== Enable ViewportTest. This test passes as is. It was disabled due to a temporary regression that cleared up a long time ago. BUG= ========== to ========== Enable testDefaultViewportSize. This test passes as is. It was disabled due to a temporary regression that cleared up a long time ago. BUG= ==========
The CQ bit was checked by aelias@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624763002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)
Description was changed from ========== Enable testDefaultViewportSize. This test passes as is. It was disabled due to a temporary regression that cleared up a long time ago. BUG= ========== to ========== Enable testDefaultViewportSize. This test passes as is. It was disabled due to a temporary regression that cleared up a long time ago. BUG=580744 ==========
aelias@chromium.org changed reviewers: + yfriedman@chromium.org
Hi Yaron, PTAL.
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
On 2016/01/23 01:00:55, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, no build URL) > chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux > (JOB_FAILED, no build URL) > chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux > (JOB_FAILED, no build URL) > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL) > linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, > no build URL) > linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no > build URL) > linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, no > build URL) > linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no > build URL) > linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no > build URL) > linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, no > build URL) > linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) There was a problem with these builders. I've pressed dry-run again.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624763002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
lgtm
The CQ bit was checked by aelias@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624763002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable testDefaultViewportSize. This test passes as is. It was disabled due to a temporary regression that cleared up a long time ago. BUG=580744 ========== to ========== Enable testDefaultViewportSize. This test passes as is. It was disabled due to a temporary regression that cleared up a long time ago. BUG=580744 Committed: https://crrev.com/f7bf6ca8d00fa950422bf8c4d4ecf2c6d05bb547 Cr-Commit-Position: refs/heads/master@{#371449} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f7bf6ca8d00fa950422bf8c4d4ecf2c6d05bb547 Cr-Commit-Position: refs/heads/master@{#371449} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
