Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5279)

Unified Diff: chrome/chrome_browser.gypi

Issue 1624723002: Move remote_db_manager into the safe_browsing_db component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initialize the pointer to nullptr and check null before using. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 0ba9fbc8590e8952e07369618a2ceb8139c3f7de..7caa3cdf5c9d63a14178c916178ef6f50edd129d 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -2524,12 +2524,6 @@
'chrome_browser_safe_browsing_mobile_sources': [
'browser/renderer_host/safe_browsing_resource_throttle.cc',
'browser/renderer_host/safe_browsing_resource_throttle.h',
- 'browser/safe_browsing/remote_database_manager.cc',
- 'browser/safe_browsing/remote_database_manager.h',
- 'browser/safe_browsing/safe_browsing_api_handler.cc',
- 'browser/safe_browsing/safe_browsing_api_handler.h',
- 'browser/safe_browsing/safe_browsing_api_handler_util.cc',
- 'browser/safe_browsing/safe_browsing_api_handler_util.h',
],
# "Safe Browsing Full" files in addition to the "basic" ones to use for
# full safe browsing. This has some in common with "mobile."
@@ -3553,9 +3547,9 @@
'sources': [ '<@(chrome_browser_safe_browsing_basic_sources)' ],
'dependencies': [
'safe_browsing_chunk_proto',
- 'safe_browsing_metadata_proto',
'safe_browsing_proto',
'../components/components.gyp:safe_browsing_db',
+ '../components/components.gyp:safe_browsing_metadata_proto',
],
'conditions': [
['safe_browsing == 1', {
@@ -3575,6 +3569,7 @@
'sources': [ '<@(chrome_browser_safe_browsing_mobile_sources)' ],
'dependencies': [
'safe_browsing_proto',
+ '../components/components.gyp:safe_browsing_db_mobile',
],
}],
],
@@ -3985,19 +3980,6 @@
'includes': [ '../build/protoc.gypi' ]
},
{
- # Protobuf compiler / generator for the safebrowsing full hash metadata
- # protocol buffer.
- # GN version: //chrome/browser/safe_browsing:metadata_proto
- 'target_name': 'safe_browsing_metadata_proto',
- 'type': 'static_library',
- 'sources': [ 'browser/safe_browsing/metadata.proto' ],
- 'variables': {
- 'proto_in_dir': 'browser/safe_browsing',
- 'proto_out_dir': 'chrome/browser/safe_browsing',
- },
- 'includes': [ '../build/protoc.gypi' ]
- },
- {
# Protobuf compiler / generator for the safebrowsing incident reporting
# service state store data protocol buffer.
# GN version: //chrome/browser/safe_browsing/incident_reporting:state_store_data_proto

Powered by Google App Engine
This is Rietveld 408576698