Move remote_db_manager into the safe_browsing_db component.

Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen@chromium.org,blundell@chromium.org
BUG=543161
Committed: https://crrev.com/27f7e227bffc205b913237ab3a080210aadf5a1b
Cr-Commit-Position: refs/heads/master@{#373073}

[vakh (use Gerrit instead), 2016-01-22 22:30:09]

Initialize the pointer to nullptr and check null before using.

[vakh (use Gerrit instead), 2016-01-22 22:36:33]

vakh@chromium.org changed reviewers:
+ jochen@chromium.org, nparker@chromium.org

[vakh (use Gerrit instead), 2016-01-22 22:36:34]

nparker@chromium.org, blundell@chromium.org: Please review changes in:
components/...

jochen@chromium.org: Please review changes in 
chrome/...

shess@chromium.org: FYI, since you are the sheriff, but please feel free to
review.

[vakh (use Gerrit instead), 2016-01-22 22:36:51]

vakh@chromium.org changed reviewers:
+ blundell@chromium.org

[Nathan Parker, 2016-01-22 22:46:20]

https://codereview.chromium.org/1624723002/diff/20001/components/safe_browsin...
File components/safe_browsing_db/safe_browsing_api_handler_util.cc (right):

https://codereview.chromium.org/1624723002/diff/20001/components/safe_browsin...
components/safe_browsing_db/safe_browsing_api_handler_util.cc:138: if (matches)
{
How about instead adding a "|| !matches" at the end of the above if(), so we
return an error rather than silently returning nothing?

[blundell, 2016-01-25 08:58:18]

On 2016/01/22 22:46:20, nparker wrote:
>
https://codereview.chromium.org/1624723002/diff/20001/components/safe_browsin...
> File components/safe_browsing_db/safe_browsing_api_handler_util.cc (right):
> 
>
https://codereview.chromium.org/1624723002/diff/20001/components/safe_browsin...
> components/safe_browsing_db/safe_browsing_api_handler_util.cc:138: if
(matches)
> {
> How about instead adding a "|| !matches" at the end of the above if(), so we
> return an error rather than silently returning nothing?

I think you can just get Nathan's review on this and TBR everyone else since
you're not making any other changes from the first go-round as far as I can see.

[vakh (use Gerrit instead), 2016-01-26 18:37:45]

git cl format

[vakh (use Gerrit instead), 2016-01-26 19:58:09]

On 2016/01/25 08:58:18, blundell wrote:
> On 2016/01/22 22:46:20, nparker wrote:
> >
>
https://codereview.chromium.org/1624723002/diff/20001/components/safe_browsin...
> > File components/safe_browsing_db/safe_browsing_api_handler_util.cc (right):
> > 
> >
>
https://codereview.chromium.org/1624723002/diff/20001/components/safe_browsin...
> > components/safe_browsing_db/safe_browsing_api_handler_util.cc:138: if
> (matches)
> > {
> > How about instead adding a "|| !matches" at the end of the above if(), so we
> > return an error rather than silently returning nothing?
> 
> I think you can just get Nathan's review on this and TBR everyone else since
> you're not making any other changes from the first go-round as far as I can
see.

Good point. Done.

[Nathan Parker, 2016-01-29 19:39:32]

lgtm

[Nathan Parker, 2016-02-02 21:37:21]

The CQ bit was checked by nparker@chromium.org

[vakh (use Gerrit instead), 2016-02-02 21:38:30]

Description was changed from

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

BUG=543161
==========

to

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen,blundell
BUG=543161
==========

[vakh (use Gerrit instead), 2016-02-02 21:39:40]

Description was changed from

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen,blundell
BUG=543161
==========

to

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen@chromium.org,blundell@chromium.org
BUG=543161
==========

[commit-bot: I haz the power, 2016-02-02 21:43:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624723002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624723002/40001

[commit-bot: I haz the power, 2016-02-02 21:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 21:52:11]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vakh (use Gerrit instead), 2016-02-02 21:59:11]

fetch, rebase, format

[Nathan Parker, 2016-02-02 23:14:19]

The CQ bit was checked by nparker@chromium.org

[Nathan Parker, 2016-02-02 23:14:19]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1624723002/#ps60001
(title: "fetch, rebase, format")

[commit-bot: I haz the power, 2016-02-02 23:19:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624723002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624723002/60001

[commit-bot: I haz the power, 2016-02-02 23:45:49]

Description was changed from

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen@chromium.org,blundell@chromium.org
BUG=543161
==========

to

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen@chromium.org,blundell@chromium.org
BUG=543161
==========

[commit-bot: I haz the power, 2016-02-02 23:45:50]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-02 23:46:42]

Description was changed from

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen@chromium.org,blundell@chromium.org
BUG=543161
==========

to

==========
Move remote_db_manager into the safe_browsing_db component.

This reverts commit 2b17e4a37d9c71a1cafdb77688fe344a5034341c.
Original CL: https://codereview.chromium.org/1579403002/
Revert CL: https://codereview.chromium.org/1620813005/

TBR=jochen@chromium.org,blundell@chromium.org
BUG=543161

Committed: https://crrev.com/27f7e227bffc205b913237ab3a080210aadf5a1b
Cr-Commit-Position: refs/heads/master@{#373073}
==========

[commit-bot: I haz the power, 2016-02-02 23:46:44]

Patchset 4 (id:??) landed as
https://crrev.com/27f7e227bffc205b913237ab3a080210aadf5a1b
Cr-Commit-Position: refs/heads/master@{#373073}