Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: cc/trees/property_tree_builder.cc

Issue 1624693004: cc:: Add transform nodes at boundaries of 3d rendering contexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/trees/property_tree.h ('K') | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree_builder.cc
diff --git a/cc/trees/property_tree_builder.cc b/cc/trees/property_tree_builder.cc
index a27bd3c8bf6e0d2575138592243cdb29d565bcf1..a8c01e240de7f5027e0db7cdf052b47a3fe90ab8 100644
--- a/cc/trees/property_tree_builder.cc
+++ b/cc/trees/property_tree_builder.cc
@@ -197,6 +197,19 @@ void AddClipNodeIfNeeded(const DataForRecursion<LayerType>& data_from_ancestor,
}
template <typename LayerType>
+static bool IsRootLayerOfNewRenderingContext(LayerType* layer) {
+ if (layer->parent())
+ return !layer->parent()->Is3dSorted() && layer->Is3dSorted();
+ return layer->Is3dSorted();
+}
+
+template <typename LayerType>
+static bool EndsExisiting3dRenderingContext(LayerType* layer) {
+ return layer->parent() ? layer->parent()->Is3dSorted() && !layer->Is3dSorted()
+ : false;
+}
+
+template <typename LayerType>
bool AddTransformNodeIfNeeded(
const DataForRecursion<LayerType>& data_from_ancestor,
LayerType* layer,
@@ -232,10 +245,16 @@ bool AddTransformNodeIfNeeded(
layer->parent()->effect_tree_index() !=
layer->scroll_parent()->effect_tree_index();
+ const bool is_root_of_new_rendering_context =
+ IsRootLayerOfNewRenderingContext(layer);
+ const bool ends_3d_rendering_context = EndsExisiting3dRenderingContext(layer);
+
bool requires_node = is_root || is_scrollable || has_significant_transform ||
has_any_transform_animation || has_surface || is_fixed ||
is_page_scale_layer || is_overscroll_elasticity_layer ||
- scroll_child_has_different_target;
+ scroll_child_has_different_target ||
+ is_root_of_new_rendering_context ||
+ ends_3d_rendering_context;
LayerType* transform_parent = GetTransformParent(data_from_ancestor, layer);
DCHECK(is_root || transform_parent);
@@ -312,6 +331,8 @@ bool AddTransformNodeIfNeeded(
node->data.scrolls = is_scrollable;
node->data.flattens_inherited_transform = data_for_children->should_flatten;
+ node->data.is_3d_sorted = layer->Is3dSorted();
+
if (layer == data_from_ancestor.page_scale_layer)
data_for_children->in_subtree_of_page_scale_layer = true;
node->data.in_subtree_of_page_scale_layer =
« cc/trees/property_tree.h ('K') | « cc/trees/property_tree.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698