Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1624693003: Ignore WebViewPlatformBridge apk when merging apks (Closed)

Created:
4 years, 11 months ago by sgurun-gerrit only
Modified:
4 years, 11 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore WebViewPlatformBridge apk when merging apks BUG=546822 The apk is failing comparison because of timestamps not content difference, so ignore it for now. Committed: https://crrev.com/fd17f011bbafa4e6e5e98e616a1cbf1a6580f968 Cr-Commit-Position: refs/heads/master@{#371077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M android_webview/tools/apk_merger.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
sgurun-gerrit only
On 2016/01/22 22:13:27, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:torne@chromium.org ptal, thanks
4 years, 11 months ago (2016-01-22 22:13:36 UTC) #3
Torne
lgtm
4 years, 11 months ago (2016-01-22 22:17:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624693003/1
4 years, 11 months ago (2016-01-22 22:20:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 23:30:07 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 23:31:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd17f011bbafa4e6e5e98e616a1cbf1a6580f968
Cr-Commit-Position: refs/heads/master@{#371077}

Powered by Google App Engine
This is Rietveld 408576698