Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 1624643003: ICU 56 step 2: Make the tree ready for local modifications (Closed)

Created:
4 years, 11 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@561upstream
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ICU 56 step 2 Make the tree ready for the application Google's and Chrome's data and post-56 code patches. 1. Fix trim_data.sh to run from anywhere. 2. Update patch_locale.sh for Android and add en_IN to the locale list 3. Apply data.build.patch 4. Exclude non-UI locale data for unit locale category 5. Add some regional variant locales to locale, unit, zone and coll. 6. Update locale lists for locale, unit, zone, and coll BUG=575007 TEST=None R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/27b09232f96145d44d3845ccc2abb94761e9b267

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -79 lines) Patch
M android/patch_locale.sh View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M scripts/trim_data.sh View 1 2 5 chunks +9 lines, -6 lines 0 comments Download
M source/data/Makefile.in View 4 chunks +15 lines, -4 lines 0 comments Download
M source/data/coll/collocal.mk View 1 chunk +1 line, -1 line 0 comments Download
M source/data/curr/reslocal.mk View 1 chunk +1 line, -1 line 0 comments Download
M source/data/locales/reslocal.mk View 1 chunk +2 lines, -1 line 0 comments Download
M source/data/unit/reslocal.mk View 2 chunks +4 lines, -57 lines 0 comments Download
M source/data/zone/reslocal.mk View 1 chunk +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
jungshik at Google
Hi Mark, Can you take a look at the changes in two scripts? This is ...
4 years, 11 months ago (2016-01-28 08:46:32 UTC) #4
Mark Mentovai
LGTM https://codereview.chromium.org/1624643003/diff/20001/android/patch_locale.sh File android/patch_locale.sh (right): https://codereview.chromium.org/1624643003/diff/20001/android/patch_locale.sh#newcode10 android/patch_locale.sh:10: patch -p1 < android/brkitr.patch || { echo "failed ...
4 years, 10 months ago (2016-01-28 14:17:52 UTC) #5
jungshik at Google
Thanks ! With the review comments addressed, I'm landing it. https://codereview.chromium.org/1624643003/diff/20001/android/patch_locale.sh File android/patch_locale.sh (right): https://codereview.chromium.org/1624643003/diff/20001/android/patch_locale.sh#newcode10 ...
4 years, 10 months ago (2016-01-29 08:14:28 UTC) #6
jungshik at Google
4 years, 10 months ago (2016-01-29 08:48:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
27b09232f96145d44d3845ccc2abb94761e9b267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698