Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5422)

Unified Diff: chrome/browser/views/tabs/dragged_tab_controller.h

Issue 16246: CRASH at Tab::OnMouseReleased... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/tabs/dragged_tab_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/tabs/dragged_tab_controller.h
===================================================================
--- chrome/browser/views/tabs/dragged_tab_controller.h (revision 7580)
+++ chrome/browser/views/tabs/dragged_tab_controller.h (working copy)
@@ -57,8 +57,8 @@
// Complete the current drag session. If the drag session was canceled
// because the user pressed Escape or something interrupted it, |canceled|
// is true so the helper can revert the state to the world before the drag
- // begun.
- void EndDrag(bool canceled);
+ // begun. Returns whether the tab has been destroyed.
+ bool EndDrag(bool canceled);
// Retrieve the source Tab if the TabContents specified matches the one being
// dragged by this controller, or NULL if the specified TabContents is not
@@ -186,8 +186,8 @@
// dragged TabContents.
Tab* GetTabMatchingDraggedContents(TabStrip* tabstrip) const;
- // Does the work for EndDrag.
- void EndDragImpl(EndDragType how_end);
+ // Does the work for EndDrag. Returns whether the tab has been destroyed.
+ bool EndDragImpl(EndDragType how_end);
// If the drag was aborted for some reason, this function is called to un-do
// the changes made during the drag operation.
« no previous file with comments | « no previous file | chrome/browser/views/tabs/dragged_tab_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698