CRASH at Tab::OnMouseReleased...

chrome/browser/views/tabs/dragged_tab_controller.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <math.h>
 #include <set>
 
 #include "chrome/browser/views/tabs/dragged_tab_controller.h"
 
 #include "chrome/browser/browser_window.h"
@@ skipping 337 matching lines @@
   // attached to the source tabstrip.
   if (source_tab_->IsVisible() && CanStartDrag())
     Attach(source_tabstrip_, gfx::Point());
 
   if (!source_tab_->IsVisible()) {
     SaveFocus();
     ContinueDragging();
   }
 }
 
-void DraggedTabController::EndDrag(bool canceled) {
-  EndDragImpl(canceled ? CANCELED : NORMAL);
+bool DraggedTabController::EndDrag(bool canceled) {
+  return EndDragImpl(canceled ? CANCELED : NORMAL);
 }
 
 Tab* DraggedTabController::GetDragSourceTabForContents(
     TabContents* contents) const {
   if (attached_tabstrip_ == source_tabstrip_)
     return contents == dragged_contents_ ? source_tab_ : NULL;
   return NULL;
 }
 
 bool DraggedTabController::IsDragSourceTab(Tab* tab) const {
@@ skipping 544 matching lines @@
   return gfx::Point(x, y);
 }
 
 
 Tab* DraggedTabController::GetTabMatchingDraggedContents(
     TabStrip* tabstrip) const {
   int index = tabstrip->model()->GetIndexOfTabContents(dragged_contents_);
   return index == TabStripModel::kNoTab ? NULL : tabstrip->GetTabAt(index);
 }
 
-void DraggedTabController::EndDragImpl(EndDragType type) {
+bool DraggedTabController::EndDragImpl(EndDragType type) {
   bring_to_front_timer_.Stop();
 
   // Hide the current dock controllers.
   for (size_t i = 0; i < dock_controllers_.size(); ++i) {
     // Be sure and clear the controller first, that way if Hide ends up
     // deleting the controller it won't call us back.
     dock_controllers_[i]->clear_controller();
     dock_controllers_[i]->Hide();
   }
   dock_controllers_.clear();
@@ skipping 17 matching lines @@
     // attempt to do any cleanup other than resetting the delegate (if we're
     // still the delegate).
     if (dragged_contents_ && dragged_contents_->delegate() == this)
       dragged_contents_->set_delegate(NULL);
     dragged_contents_ = NULL;
     attached_tabstrip_ = NULL;
   }
   // If we're not destroyed now, we'll be destroyed asynchronously later.
   if (destroy_now)
     source_tabstrip_->DestroyDragController();
+
+  return destroy_now;
 }
 
 void DraggedTabController::RevertDrag() {
   // We save this here because code below will modify |attached_tabstrip_|.
   bool restore_frame = attached_tabstrip_ != source_tabstrip_;
   if (attached_tabstrip_) {
     int index = attached_tabstrip_->model()->GetIndexOfTabContents(
         dragged_contents_);
     if (attached_tabstrip_ != source_tabstrip_) {
       // The Tab was inserted into another TabStrip. We need to put it back
@@ skipping 219 matching lines @@
     // Move the window to the front.
     SetWindowPos(hwnd, HWND_TOP, 0, 0, 0, 0,
                  SWP_NOACTIVATE | SWP_NOMOVE | SWP_NOSIZE);
 
     // The previous call made the window appear on top of the dragged window,
     // move the dragged window to the front.
     SetWindowPos(view_->GetWidget()->GetHWND(), HWND_TOP, 0, 0, 0, 0,
                  SWP_NOACTIVATE | SWP_NOMOVE | SWP_NOSIZE);
   }
 }