Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1624593002: Adds targets for simarmv6 and armv6 (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add xcode settings for simarmv6 and v5te #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -17 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tools/gyp/runtime-configurations.gypi View 1 1 chunk +14 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/cpu_arm.cc View 2 chunks +7 lines, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/standalone.status View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/pkg_tested/pkg_tested.status View 1 chunk +1 line, -1 line 0 comments Download
M tools/build.py View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/gyp/configurations.gypi View 5 chunks +75 lines, -0 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 2 chunks +35 lines, -0 lines 0 comments Download
M tools/gyp/configurations_msvs.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gyp/configurations_xcode.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/utils.py View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 11 months ago (2016-01-22 19:01:25 UTC) #2
rmacnak
LGTM
4 years, 11 months ago (2016-01-22 20:41:46 UTC) #3
zra
4 years, 11 months ago (2016-01-22 21:07:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
80f358dede21f5b01216262d204049f65fcb9e70.

Powered by Google App Engine
This is Rietveld 408576698