Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1624543002: [Autofill] Remove GZIP compression since requests are now in proto (Closed)

Created:
4 years, 11 months ago by Mathieu
Modified:
4 years, 10 months ago
CC:
chromium-reviews, droger+watchlist_chromium.org, rouslan+autofill_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, asvitkine+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Remove GZIP compression since requests are now in proto GZIP is detrimental. BUG=580102 TEST=AutofillDownloadManager TBR=asvitkine Committed: https://crrev.com/22abec6057fd7ac143e3eb1eb3c89de41b07cbb4 Cr-Commit-Position: refs/heads/master@{#372103}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -195 lines) Patch
M chrome/browser/autofill/autofill_server_browsertest.cc View 5 chunks +3 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_download_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 1 3 chunks +2 lines, -16 lines 0 comments Download
M components/autofill/core/browser/autofill_download_manager_unittest.cc View 3 chunks +0 lines, -136 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 2 chunks +0 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Mathieu
Hi Vaclav, would you have a look? Thanks!
4 years, 11 months ago (2016-01-27 18:53:50 UTC) #3
vabr (Chromium)
LGTM, love to see the code getting simpler. Cheers, Vaclav
4 years, 10 months ago (2016-01-28 10:01:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624543002/1
4 years, 10 months ago (2016-01-28 13:12:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/164725) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-01-28 13:14:55 UTC) #8
Mathieu
Thanks! rebased, and TBR asvitkine because I'm marking a histogram as obsolete so the change ...
4 years, 10 months ago (2016-01-28 14:33:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624543002/20001
4 years, 10 months ago (2016-01-28 14:34:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 16:39:08 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/22abec6057fd7ac143e3eb1eb3c89de41b07cbb4 Cr-Commit-Position: refs/heads/master@{#372103}
4 years, 10 months ago (2016-01-28 16:40:32 UTC) #18
Alexei Svitkine (slow)
4 years, 10 months ago (2016-01-28 17:25:16 UTC) #19
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698