Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/IceInstARM32.cpp

Issue 1624383004: Add VMOV(immediate) instructions to the ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix issues in previous patch. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index 5f4991f001d2cabb7cbabb9963d0204a22b999f3..a2f04c95009f534921ca47d0f70ccee5f239b558 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1124,6 +1124,32 @@ void InstARM32Mov::emitSingleDestSingleSource(const Cfg *Func) const {
Src0->emit(Func);
}
+void InstARM32Mov::emitIASScalarVFPMove(const Cfg *Func) const {
+ auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
+ Operand *Src0 = getSrc(0);
+ Variable *Dest = getDest();
+ switch (Dest->getType()) {
+ default:
+ assert(false && "Do not know how to emit scalar FP move for type.");
+ return;
+ case IceType_f32:
+ if (const auto *FpImm = llvm::dyn_cast<OperandARM32FlexFpImm>(Src0)) {
+ Asm->vmovs(Dest, FpImm, getPredicate());
+ return;
+ }
+ break;
+ case IceType_f64:
+ if (const auto *FpImm = llvm::dyn_cast<OperandARM32FlexFpImm>(Src0)) {
+ Asm->vmovd(Dest, FpImm, getPredicate());
+ return;
+ }
+ break;
+ }
+ // TODO(kschimpf) Handle register to register move.
+ Asm->setNeedsTextFixup();
+ return;
+}
+
void InstARM32Mov::emitIASCoreVFPMove(const Cfg *Func) const {
auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
Operand *Src0 = getSrc(0);
@@ -1149,7 +1175,6 @@ void InstARM32Mov::emitIASCoreVFPMove(const Cfg *Func) const {
}
void InstARM32Mov::emitIASSingleDestSingleSource(const Cfg *Func) const {
- auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
Variable *Dest = getDest();
Operand *Src0 = getSrc(0);
@@ -1166,8 +1191,9 @@ void InstARM32Mov::emitIASSingleDestSingleSource(const Cfg *Func) const {
const Type DestTy = Dest->getType();
if (isScalarFloatingType(DestTy))
- return Asm->setNeedsTextFixup();
+ return emitIASScalarVFPMove(Func);
+ auto *Asm = Func->getAssembler<ARM32::AssemblerARM32>();
if (isVectorType(DestTy))
return Asm->setNeedsTextFixup();

Powered by Google App Engine
This is Rietveld 408576698