Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1624383003: Restore per-TypedArray-class length accessors as a perf workaround (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Restore per-TypedArray-class length accessors as a perf workaround This patch is a workaround to the performance regression caused by implementing the ES2015 TypedArray prototype chain: Include a per-TypedArray-subclass length getter so that the superclass getter does not become polymorphic. The patch appears to fix a regression in the Gameboy Octane benchmark. BUG=chromium:579905 R=adamk LOG=Y Committed: https://crrev.com/03ce7711e474a0ef74f723b30ae1527c89dec010 Cr-Commit-Position: refs/heads/master@{#33501}

Patch Set 1 #

Total comments: 1

Patch Set 2 : More TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M src/js/typedarray.js View 1 2 chunks +11 lines, -0 lines 0 comments Download
M test/mjsunit/es6/typedarray-proto.js View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Dan Ehrenberg
4 years, 11 months ago (2016-01-25 19:00:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624383003/1
4 years, 11 months ago (2016-01-25 19:00:34 UTC) #3
adamk
lgtm % one more TODO https://codereview.chromium.org/1624383003/diff/1/src/js/typedarray.js File src/js/typedarray.js (right): https://codereview.chromium.org/1624383003/diff/1/src/js/typedarray.js#newcode839 src/js/typedarray.js:839: utils.InstallGetter(GlobalNAME.prototype, "length", NAME_GetLength, Please ...
4 years, 11 months ago (2016-01-25 19:21:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 19:44:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624383003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624383003/20001
4 years, 11 months ago (2016-01-25 20:05:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 20:25:41 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/03ce7711e474a0ef74f723b30ae1527c89dec010 Cr-Commit-Position: refs/heads/master@{#33501}
4 years, 11 months ago (2016-01-25 20:26:55 UTC) #12
Dan Ehrenberg
4 years, 9 months ago (2016-03-18 18:03:47 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1812143004/ by littledan@chromium.org.

The reason for reverting is: This patch actually seemed to cause a further
GameBoy regression! Reverting it seems to address the regression.

BUG=chromium:593634.

Powered by Google App Engine
This is Rietveld 408576698