Match <area shape> ASCII case-insensitively

Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character
is case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2] https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
Committed: https://crrev.com/07a9d8301ec2709af99986b69a7704570aff08db
Cr-Commit-Position: refs/heads/master@{#371478}

[fs, 2016-01-25 19:23:17]

Description was changed from

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

BUG=578125
==========

to

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

[fs, 2016-01-25 19:28:18]

fs@opera.com changed reviewers:
+ tkent@chromium.org

[fs, 2016-01-25 19:28:19]

No effect on the specified test because:

a) Invalid/missing value default is not per spec, so the unexpected shape is
picked anyway.

but more importantly:

b) the way case-folding is implemented/specified, no non-ASCII character is
case-folded to something in the ASCII-range.

But I guess it shows intent...

[tkent, 2016-01-26 00:00:47]

lgtm

On 2016/01/25 at 19:28:19, fs wrote:
> No effect on the specified test because:
> 
> a) Invalid/missing value default is not per spec, so the unexpected shape is
picked anyway.
> 
> but more importantly:
> 
> b) the way case-folding is implemented/specified, no non-ASCII character is
case-folded to something in the ASCII-range.
> 
> But I guess it shows intent...

The CL description should have this information.

[fs, 2016-01-26 08:54:37]

Description was changed from

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

to

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape is
picked anyway.
but more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character is
case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

[fs, 2016-01-26 08:54:59]

Description was changed from

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape is
picked anyway.
but more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character is
case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

to

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character is
case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

[fs, 2016-01-26 08:55:12]

Description was changed from

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character is
case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

to

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character
is case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

[fs, 2016-01-26 08:55:38]

On 2016/01/26 at 00:00:47, tkent wrote:
> lgtm

Thanks.
 
> On 2016/01/25 at 19:28:19, fs wrote:
> > No effect on the specified test because:
> > 
> > a) Invalid/missing value default is not per spec, so the unexpected shape is
picked anyway.
> > 
> > but more importantly:
> > 
> > b) the way case-folding is implemented/specified, no non-ASCII character is
case-folded to something in the ASCII-range.
> > 
> > But I guess it shows intent...
> 
> The CL description should have this information.

Transferred there.

[fs, 2016-01-26 08:55:45]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-01-26 08:55:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624383002/1

[commit-bot: I haz the power, 2016-01-26 08:59:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 09:01:03]

Description was changed from

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character
is case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125
==========

to

==========
Match <area shape> ASCII case-insensitively

The 'shape' attribute on HTMLAreaElement is an "enumerated attribute"
[1], which means that it should be matched ASCII case-insensitively[2].

To get a proper overload of equalIgnoringASCIICase(...) that matches the
required use (AtomicString against string literal/const char*),
restructure the definition of equalIgnoringASCIICase() to do away with
the templated version in favor of a generic StringImpl* version, and
specific wrappers around that one for AtomicString/String.
Also add a specialization for comparing against char/LChar.

No effect on the specified test because:
a) Invalid/missing value default is not per spec, so the unexpected shape
is picked anyway.
But more importantly:
b) the way case-folding is implemented/specified, no non-ASCII character
is case-folded to something in the ASCII-range.

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape
[2]
https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

TEST=fast/html/area-shape.html
BUG=578125

Committed: https://crrev.com/07a9d8301ec2709af99986b69a7704570aff08db
Cr-Commit-Position: refs/heads/master@{#371478}
==========

[commit-bot: I haz the power, 2016-01-26 09:01:03]

Patchset 1 (id:??) landed as
https://crrev.com/07a9d8301ec2709af99986b69a7704570aff08db
Cr-Commit-Position: refs/heads/master@{#371478}