ui/views/widget/widget_removals_observer.h - Issue 1624343003: Minor fixes for WidgetRemovalsObserver::OnWillRemoveView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget_removals_observer.h

Issue 1624343003: Minor fixes for WidgetRemovalsObserver::OnWillRemoveView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/widget_removals_observer.h

diff --git a/ui/views/widget/widget_removals_observer.h b/ui/views/widget/widget_removals_observer.h

index e62acab36a482c7463e28afe481053a13efeb3f0..d7046073c4d56055c9372f258867c0b6a964daf2 100644

--- a/ui/views/widget/widget_removals_observer.h

+++ b/ui/views/widget/widget_removals_observer.h

@@ -18,7 +18,11 @@ class View;

// from |View|.

class VIEWS_EXPORT WidgetRemovalsObserver {

public:

- // Called immediately before a descendant view of |widget| is removed.

+ // Called immediately before a descendant view of |widget| is removed

+ // from this widget. Won't be called if the view is moved within the

+ // same widget, but will be called if it's moved to a different widget.

+ // Only called on the root of a view tree; it implies that all of the

+ // descendants of |view| will be removed.

virtual void OnWillRemoveView(Widget* widget, View* view) {}

protected:

« no previous file with comments | « ui/views/view.cc ('k') | ui/views/widget/widget_unittest.cc » ('j') | no next file with comments »