Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 162433002: [Telemetry] Fix cros running locally. (Closed)

Created:
6 years, 10 months ago by tonyg
Modified:
6 years, 10 months ago
Reviewers:
achuithb, Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix cros running locally. This was broken by my recent forwarder refactor. BUG= Notry=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
tonyg
6 years, 10 months ago (2014-02-13 01:07:06 UTC) #1
tonyg
6 years, 10 months ago (2014-02-13 01:10:06 UTC) #2
achuithb
Lgtm, thanks!
6 years, 10 months ago (2014-02-13 01:16:34 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-13 01:17:11 UTC) #4
tonyg
On 2014/02/13 01:16:34, achuith.bhandarkar wrote: > Lgtm, thanks! Turns out that assert was just what ...
6 years, 10 months ago (2014-02-13 01:17:29 UTC) #5
Tim Song
lgtm
6 years, 10 months ago (2014-02-13 01:20:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/162433002/1
6 years, 10 months ago (2014-02-13 01:20:17 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 04:47:25 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263211
6 years, 10 months ago (2014-02-13 04:47:26 UTC) #9
achuithb
Cros-only change doesn't affect bots.
6 years, 10 months ago (2014-02-13 05:27:26 UTC) #10
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 10 months ago (2014-02-13 05:27:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/162433002/1
6 years, 10 months ago (2014-02-13 05:28:19 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:01:40 UTC) #13
Message was sent while issue was closed. 
Change committed as 251008

Powered by Google App Engine
This is Rietveld 408576698