Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 1624323003: [wasm] Put the condition last in kExprSelect. (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Put the condition last in kExprSelect. To bring V8 into line with the proposed design changes in: https://github.com/WebAssembly/design/pull/489 R=ahaas@chromium.org,bradnelson@chromium.org LOG=Y BUG=chromium:575167 BUG=v8:4735 Committed: https://crrev.com/59b922fb4eac90ac466711f8e1aa147403987d8e Cr-Commit-Position: refs/heads/master@{#33776}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -22 lines) Patch
M src/wasm/ast-decoder.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 chunks +29 lines, -13 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 1 1 chunk +44 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
titzer
4 years, 11 months ago (2016-01-25 14:26:20 UTC) #1
ahaas
lgtm
4 years, 11 months ago (2016-01-25 15:59:26 UTC) #2
bradnelson
lgtm
4 years, 11 months ago (2016-01-25 18:46:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624323003/20001
4 years, 10 months ago (2016-02-05 13:32:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 13:34:47 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 13:35:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59b922fb4eac90ac466711f8e1aa147403987d8e
Cr-Commit-Position: refs/heads/master@{#33776}

Powered by Google App Engine
This is Rietveld 408576698