Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager.cc

Issue 162423002: [WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/permission_bubble_manager.cc
diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager.cc b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
index c6d4141a0bea6f5012f241766a01bce1db307bdc..97864ddde84228af4c4ae0f1570ddf1eac7e6979 100644
--- a/chrome/browser/ui/website_settings/permission_bubble_manager.cc
+++ b/chrome/browser/ui/website_settings/permission_bubble_manager.cc
@@ -168,17 +168,15 @@ void PermissionBubbleManager::Closing() {
void PermissionBubbleManager::ShowBubble() {
if (view_ && !bubble_showing_ && requests_.size()) {
- view_->SetDelegate(this);
view_->Show(requests_, accept_states_, customization_mode_);
bubble_showing_ = true;
}
}
void PermissionBubbleManager::FinalizeBubble() {
- if (view_) {
- view_->SetDelegate(NULL);
+ if (view_)
view_->Hide();
- }
+ bubble_showing_ = false;
std::vector<PermissionBubbleRequest*>::iterator requests_iter;
for (requests_iter = requests_.begin();
@@ -188,7 +186,6 @@ void PermissionBubbleManager::FinalizeBubble() {
}
requests_.clear();
accept_states_.clear();
- bubble_showing_ = false;
if (queued_requests_.size()) {
requests_ = queued_requests_;
accept_states_.resize(requests_.size(), true);
« no previous file with comments | « no previous file | chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698