Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

Issue 162423002: [WebsiteSettings] Fix bug in permission bubble manager to alter showing state when bubble is closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h" 8 #include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
9 #include "chrome/browser/ui/website_settings/permission_bubble_request.h" 9 #include "chrome/browser/ui/website_settings/permission_bubble_request.h"
10 #include "chrome/browser/ui/website_settings/permission_bubble_view.h" 10 #include "chrome/browser/ui/website_settings/permission_bubble_view.h"
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 manager_->AddRequest(&request1_); 276 manager_->AddRequest(&request1_);
277 manager_->AddRequest(&request2_); 277 manager_->AddRequest(&request2_);
278 manager_->AddRequest(&request1_); 278 manager_->AddRequest(&request1_);
279 279
280 WaitForCoalescing(); 280 WaitForCoalescing();
281 EXPECT_TRUE(view_.shown_); 281 EXPECT_TRUE(view_.shown_);
282 ASSERT_EQ(2u, view_.permission_requests_.size()); 282 ASSERT_EQ(2u, view_.permission_requests_.size());
283 EXPECT_EQ(&request1_, view_.permission_requests_[0]); 283 EXPECT_EQ(&request1_, view_.permission_requests_[0]);
284 EXPECT_EQ(&request2_, view_.permission_requests_[1]); 284 EXPECT_EQ(&request2_, view_.permission_requests_[1]);
285 } 285 }
286
287 TEST_F(PermissionBubbleManagerTest, SequentialRequests) {
288 manager_->SetView(&view_);
289 manager_->AddRequest(&request1_);
290 WaitForCoalescing();
291 EXPECT_TRUE(view_.shown_);
292
293 Accept();
294 EXPECT_TRUE(request1_.granted_);
295
296 EXPECT_FALSE(view_.shown_);
297
298 manager_->AddRequest(&request2_);
299 WaitForCoalescing();
300 EXPECT_TRUE(view_.shown_);
301 Accept();
302 EXPECT_FALSE(view_.shown_);
303 EXPECT_TRUE(request2_.granted_);
304 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/website_settings/permission_bubble_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698