Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1624083003: Fix sandbox process policy tests. (Closed)

Created:
4 years, 11 months ago by Will Harris
Modified:
4 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sandbox process policy tests. These tests made invalid assumptions about the WOW64 virtualization state and were partially disabled. Now they all pass on all platforms. BUG=580800, 6944 Committed: https://crrev.com/23f88f7ffab8d61febc1dd965fb460ece194a85c Cr-Commit-Position: refs/heads/master@{#371354}

Patch Set 1 #

Patch Set 2 : rebase again after CRLF fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -59 lines) Patch
M sandbox/win/src/process_policy_test.cc View 1 15 chunks +29 lines, -47 lines 1 comment Download
M sandbox/win/tests/common/controller.h View 1 chunk +8 lines, -1 line 0 comments Download
M sandbox/win/tests/common/controller.cc View 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Will Harris
PTAL
4 years, 11 months ago (2016-01-25 03:28:57 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/1624083003/diff/20001/sandbox/win/src/process_policy_test.cc File sandbox/win/src/process_policy_test.cc (right): https://codereview.chromium.org/1624083003/diff/20001/sandbox/win/src/process_policy_test.cc#newcode282 sandbox/win/src/process_policy_test.cc:282: nice
4 years, 11 months ago (2016-01-25 22:34:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1624083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1624083003/20001
4 years, 11 months ago (2016-01-25 22:44:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 23:59:12 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:01:00 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/23f88f7ffab8d61febc1dd965fb460ece194a85c
Cr-Commit-Position: refs/heads/master@{#371354}

Powered by Google App Engine
This is Rietveld 408576698