sdk/lib/async/stream_impl.dart - Issue 16240008: Make StreamController be a StreamSink, not just an EventSink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/stream_impl.dart

Issue 16240008: Make StreamController be a StreamSink, not just an EventSink. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/async/stream_impl.dart

diff --git a/sdk/lib/async/stream_impl.dart b/sdk/lib/async/stream_impl.dart

index 85aa0833b6f0233cf7399ffb256e21aee5261169..108e42b7d7dd50fa54f1e6d4a9f5b9e86ebd6f52 100644

--- a/sdk/lib/async/stream_impl.dart

+++ b/sdk/lib/async/stream_impl.dart

@@ -719,8 +719,11 @@ class _AsBroadcastStream<T> extends Stream<T> {

onError: _controller.addError,

onDone: _controller.close);

}

- return _controller.stream.listen(onData, onError: onError, onDone: onDone,

- cancelOnError: cancelOnError);

+ if (onData == null) onData = _nullDataHandler;

+ if (onError == null) onError = _nullErrorHandler;

+ if (onDone == null) onDone = _nullDoneHandler;

+ cancelOnError = identical(true, cancelOnError);

+ return _controller._subscribe(onData, onError, onDone, cancelOnError);

}

void _onCancel() {

« no previous file with comments | « sdk/lib/async/stream_controller.dart ('k') | tests/lib/async/event_helper.dart » ('j') | no next file with comments »