Source/core/rendering/InlineBox.h - Issue 16240007: Fix hit testing to be aware of inert inlines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineBox.h

Issue 16240007: Fix hit testing to be aware of inert inlines. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: testing style Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLDialogElement/inert-inlines-expected.txt ('k') | Source/core/rendering/RenderObject.h » ('j') | Source/core/rendering/RenderObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/InlineBox.h

diff --git a/Source/core/rendering/InlineBox.h b/Source/core/rendering/InlineBox.h

index eb97253b00af9426ce333d874b420e8aca6ad230..ea0a3f77eab390198d1528dc04a75861885eb000 100644

--- a/Source/core/rendering/InlineBox.h

+++ b/Source/core/rendering/InlineBox.h

@@ -277,7 +277,7 @@ public:

int expansion() const { return m_bitfields.expansion(); }

- bool visibleToHitTestRequest(const HitTestRequest& request) const { return renderer()->style()->visibility() == VISIBLE && (request.ignorePointerEventsNone() || renderer()->style()->pointerEvents() != PE_NONE); }

+ bool visibleToHitTestRequest(const HitTestRequest& request) const { return renderer()->style()->visibility() == VISIBLE && (request.ignorePointerEventsNone() || renderer()->style()->pointerEvents() != PE_NONE) && !renderer()->isInert(); }

Hajime Morrita 2013/06/03 03:28:35 Can we factored out this somehow to getrid of dupl

falken 2013/06/03 03:47:55 Yeah it should be possible.

falken 2013/06/04 04:33:26 Done.

EVerticalAlign verticalAlign() const { return renderer()->style(m_bitfields.firstLine())->verticalAlign(); }