Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 1623693002: Tidy up in Polymer directory. (Closed)

Created:
4 years, 11 months ago by dzhioev (left Google)
Modified:
4 years, 10 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up in Polymer directory. * Updated README.chromium. * Suppressed non-zero exit status of some commands in reproduce.sh (this caused premature exit). * Added script which generates a short summary of presenting components. Presubmit complains about removed copy of README.chromium, that is why NOPRESUBMIT is set. BUG=none NOPRESUBMIT=true Committed: https://crrev.com/8071389f8e027b45339bdfd678d862799b8d6691 Cr-Commit-Position: refs/heads/master@{#371361}

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -89 lines) Patch
M third_party/polymer/README.chromium View 1 2 chunks +21 lines, -28 lines 0 comments Download
D third_party/polymer/v1_0/README.chromium View 1 chunk +0 lines, -57 lines 0 comments Download
A third_party/polymer/v1_0/components_summary.txt View 1 chunk +399 lines, -0 lines 0 comments Download
A third_party/polymer/v1_0/create_components_summary.py View 1 1 chunk +36 lines, -0 lines 1 comment Download
M third_party/polymer/v1_0/reproduce.sh View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dzhioev (left Google)
Michael, PTAL.
4 years, 11 months ago (2016-01-23 02:07:49 UTC) #3
michaelpg
nice! https://codereview.chromium.org/1623693002/diff/1/third_party/polymer/README.chromium File third_party/polymer/README.chromium (right): https://codereview.chromium.org/1623693002/diff/1/third_party/polymer/README.chromium#newcode17 third_party/polymer/README.chromium:17: https://github.com/PolymerElements/<component-name> +PolymerLabs for polymer-externs https://codereview.chromium.org/1623693002/diff/1/third_party/polymer/v1_0/create_components_summary.py File third_party/polymer/v1_0/create_components_summary.py (right): ...
4 years, 11 months ago (2016-01-23 04:28:15 UTC) #4
dzhioev (left Google)
https://codereview.chromium.org/1623693002/diff/1/third_party/polymer/README.chromium File third_party/polymer/README.chromium (right): https://codereview.chromium.org/1623693002/diff/1/third_party/polymer/README.chromium#newcode17 third_party/polymer/README.chromium:17: https://github.com/PolymerElements/<component-name> On 2016/01/23 04:28:15, michaelpg wrote: > +PolymerLabs for ...
4 years, 11 months ago (2016-01-25 23:31:35 UTC) #5
michaelpg
lgtm!
4 years, 11 months ago (2016-01-25 23:37:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623693002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623693002/20001
4 years, 11 months ago (2016-01-25 23:39:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 00:11:15 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/8071389f8e027b45339bdfd678d862799b8d6691 Cr-Commit-Position: refs/heads/master@{#371361}
4 years, 11 months ago (2016-01-26 00:12:11 UTC) #13
Dan Beam
4 years, 10 months ago (2016-02-09 02:06:02 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/1623693002/diff/20001/third_party/polymer/v1_...
File third_party/polymer/v1_0/create_components_summary.py (right):

https://codereview.chromium.org/1623693002/diff/20001/third_party/polymer/v1_...
third_party/polymer/v1_0/create_components_summary.py:33: 'tag':
info['_resolution']['tag'],
probably doesn't matter much, but when trying to test branches from the Polymer
folks (i.e. https://github.com/PolymerElements/iron-list/tree/focus-patch), at
least 'tag' isn't set

maybe we should be using .get('tag', '')?

this is an uncommon use case (so far) though

Powered by Google App Engine
This is Rietveld 408576698