Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1623643002: Fix bug when drawing background tabs in incognito windows with custom themes. (Closed)

Created:
4 years, 11 months ago by Peter Kasting
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug when drawing background tabs in incognito windows with custom themes. If a theme provided a replacement frame image, but not a replacement incognito frame or incognito background tab image, the theme service would synthesize one, but the tab drawing code would not realize this. As a result it would cache the appearance of non-hovered background tabs, leading to visual appearance glitches since not all those tabs should look the same. BUG=580677 TEST=Install https://chrome.google.com/webstore/detail/tree-branches/bgdeemcfmmabkdhbnhmkhpadancpkgol?hl=en-US , open an incognito window, open several tabs, and ensure the background tab images line up with the frame and the tab appearance doesn't change abruptly when hovering any such tabs. Committed: https://crrev.com/65740e3efadf5dad31f11b6d50eb6b63ccb3f2d7 Cr-Commit-Position: refs/heads/master@{#371081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
4 years, 11 months ago (2016-01-22 22:02:10 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-22 22:23:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623643002/1
4 years, 11 months ago (2016-01-22 22:30:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 23:37:09 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 23:39:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65740e3efadf5dad31f11b6d50eb6b63ccb3f2d7
Cr-Commit-Position: refs/heads/master@{#371081}

Powered by Google App Engine
This is Rietveld 408576698