Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 162363002: Use the new animation tween type for app list folder animation. (Closed)

Created:
6 years, 10 months ago by jennyz
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Use the new animation tween types to improve the animation effects for app list folder operation. BUG=342832 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M ui/app_list/app_list_constants.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/app_list/app_list_constants.cc View 1 chunk +14 lines, -5 lines 0 comments Download
M ui/app_list/views/app_list_folder_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/views/folder_background_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/top_icon_animation_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
jennyz
6 years, 10 months ago (2014-02-13 00:29:52 UTC) #1
xiyuan
lgtm
6 years, 10 months ago (2014-02-13 01:10:14 UTC) #2
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 10 months ago (2014-02-13 01:44:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/162363002/1
6 years, 10 months ago (2014-02-13 01:46:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:44:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 10 months ago (2014-02-13 02:44:27 UTC) #6
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 10 months ago (2014-02-13 05:28:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/162363002/1
6 years, 10 months ago (2014-02-13 05:29:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 08:35:26 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=263311
6 years, 10 months ago (2014-02-13 08:35:28 UTC) #10
jennyz
The CQ bit was checked by jennyz@chromium.org
6 years, 10 months ago (2014-02-13 17:17:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/162363002/1
6 years, 10 months ago (2014-02-13 17:18:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/162363002/1
6 years, 10 months ago (2014-02-13 19:50:52 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 21:29:22 UTC) #14
Message was sent while issue was closed.
Change committed as 251128

Powered by Google App Engine
This is Rietveld 408576698