Send enums as strings between Chromoting Native Messaging host and web-app.

remoting/webapp/host_native_messaging.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class to communicate with the Host components via Native Messaging.
  */
 
 'use strict';
@@ skipping 91 matching lines @@
 }
 
 /**
  * Returns |result| as an AsyncResult. If |result| is not valid, returns null
  * and logs an error.
  *
  * @param {*} result
  * @return {remoting.HostController.AsyncResult?} Converted result.
  */
 function asAsyncResult_(result) {
-  if (!checkType_('result', result, 'number')) {
+  if (!checkType_('result', result, 'string')) {
     return null;
   }
-  for (var i in remoting.HostController.AsyncResult) {
-    if (remoting.HostController.AsyncResult[i] == result) {
-      return remoting.HostController.AsyncResult[i];
-    }
+  if (result in remoting.HostController.AsyncResult) {
+    return remoting.HostController.AsyncResult[result];

[Sergey Ulanov, 2013/05/31 23:01:43]

nit: I would swap this block and the error case at the end. It's better when
function ends with the success case. Same for asHostState_()

[Lambros, 2013/06/03 21:28:44]

Done.

   }
   console.error('NativeMessaging: unexpected result code: ', result);
   return null;
 }
 
 /**
  * Returns |result| as a HostController.State. If |result| is not valid,
  * returns null and logs an error.
  *
  * @param {*} result
  * @return {remoting.HostController.State?} Converted result.
  */
 function asHostState_(result) {
-  if (!checkType_('result', result, 'number')) {
+  if (!checkType_('result', result, 'string')) {
     return null;
   }
-  for (var i in remoting.HostController.State) {
-    if (remoting.HostController.State[i] == result) {
-      return remoting.HostController.State[i];
-    }
+  if (result in remoting.HostController.State) {
+    return remoting.HostController.State[result];
   }
   console.error('NativeMessaging: unexpected result code: ', result);
   return null;
 }
 
 /**
  * Attaches a new ID to the supplied message, and posts it to the Native
  * Messaging port, adding |callback| to the list of pending replies.
  * |message| should have its 'type' field set, and any other fields set
  * depending on the message type.
@@ skipping 304 matching lines @@
 
 /**
  * Gets the installed/running state of the Host process.
  *
  * @param {function(remoting.HostController.State):void} callback Callback.
  * @return {void} Nothing.
  */
 remoting.HostNativeMessaging.prototype.getDaemonState = function(callback) {
   this.postMessage_({type: 'getDaemonState'}, callback);
 }