Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2637)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1623583003: Add async tracing to SWVersion::AddRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index 64c8d4325b58e5483b8b3e63b48433bde7fdabfe..2df2b135893506899293006f01035b698b2deffd 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -44,8 +44,28 @@ enum EventHandledRatioType {
NUM_EVENT_HANDLED_RATIO_TYPE,
};
+const char* const kEventTypeNames[] = {"Activate",
+ "Install",
+ "Fetch",
+ "Sync",
+ "Notification Click",
+ "Push",
+ "Geofencing",
+ "Service Port Connect",
+ "Message"};
+
+static_assert(arraysize(kEventTypeNames) ==
+ static_cast<int>(ServiceWorkerMetrics::EventType::NUM_TYPES),
+ "Names should match event types");
+
} // namespace
+const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) {
+ size_t event_type_as_int = static_cast<size_t>(event_type);
+ DCHECK(event_type_as_int < arraysize(kEventTypeNames));
+ return kEventTypeNames[event_type_as_int];
nhiroki 2016/01/25 03:50:23 switch-case could be more self-contained. That can
Marijn Kruisselbrink 2016/01/25 19:17:29 Done
+}
+
bool ServiceWorkerMetrics::ShouldExcludeSiteFromHistogram(Site site) {
return site == ServiceWorkerMetrics::Site::NEW_TAB_PAGE;
}
« no previous file with comments | « content/browser/service_worker/service_worker_metrics.h ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698