Add async tracing to SWVersion::AddRequest.

Add async tracing to SWVersion::AddRequest.

Most events already traced finishing the request, this generalizes this
to automatically trace the (browser side) duration of all events being
dispatched.

BUG=570820
Committed: https://crrev.com/0ff3b8833a882c297e798400e731f1977654e843
Cr-Commit-Position: refs/heads/master@{#371304}

[Marijn Kruisselbrink, 2016-01-22 23:50:50]

Patchset #1 (id:1) has been deleted

[Marijn Kruisselbrink, 2016-01-22 23:52:01]

Patchset #1 (id:20001) has been deleted

[Marijn Kruisselbrink, 2016-01-23 00:02:26]

mek@chromium.org changed reviewers:
+ nhiroki@chromium.org

[nhiroki, 2016-01-25 03:50:23]

LGTM

https://codereview.chromium.org/1623583003/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/1623583003/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:66: return
kEventTypeNames[event_type_as_int];
switch-case could be more self-contained. That can check whether all enum types
are appropriately handled on compile time like static_assert.

switch (event_type) {
  case EventType::ACTIVATE:
    return "Activate";
  case EventType::INSTALL:
    return "Install";
  ...
}
NOTREACHED() << event_type;
return "Unknown";

[Marijn Kruisselbrink, 2016-01-25 19:17:30]

https://codereview.chromium.org/1623583003/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.cc (right):

https://codereview.chromium.org/1623583003/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_metrics.cc:66: return
kEventTypeNames[event_type_as_int];
On 2016/01/25 at 03:50:23, nhiroki wrote:
> switch-case could be more self-contained. That can check whether all enum
types are appropriately handled on compile time like static_assert.
> 
> switch (event_type) {
>   case EventType::ACTIVATE:
>     return "Activate";
>   case EventType::INSTALL:
>     return "Install";
>   ...
> }
> NOTREACHED() << event_type;
> return "Unknown";

Done

[Marijn Kruisselbrink, 2016-01-25 19:18:08]

mek@chromium.org changed reviewers:
+ jkarlin@chromium.org

[Marijn Kruisselbrink, 2016-01-25 19:18:09]

+jkarlin for background sync OWNERS

[jkarlin, 2016-01-25 19:43:21]

background_sync/ lgtm

[Marijn Kruisselbrink, 2016-01-25 19:52:41]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-01-25 19:52:41]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1623583003/#ps60001
(title: "switch instead of array of strings")

[commit-bot: I haz the power, 2016-01-25 19:54:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1623583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1623583003/60001

[commit-bot: I haz the power, 2016-01-25 20:42:13]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-01-25 20:43:57]

Description was changed from

==========
Add async tracing to SWVersion::AddRequest.

Most events already traced finishing the request, this generalizes this
to automatically trace the (browser side) duration of all events being
dispatched.

BUG=570820
==========

to

==========
Add async tracing to SWVersion::AddRequest.

Most events already traced finishing the request, this generalizes this
to automatically trace the (browser side) duration of all events being
dispatched.

BUG=570820

Committed: https://crrev.com/0ff3b8833a882c297e798400e731f1977654e843
Cr-Commit-Position: refs/heads/master@{#371304}
==========

[commit-bot: I haz the power, 2016-01-25 20:43:58]

Patchset 2 (id:??) landed as
https://crrev.com/0ff3b8833a882c297e798400e731f1977654e843
Cr-Commit-Position: refs/heads/master@{#371304}