Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 1623563002: Revert of tools/battor_agent: Adds a tool to find connected BattOrs (Closed)

Created:
4 years, 11 months ago by Scott Hess - ex-Googler
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of tools/battor_agent: Adds a tool to find connected BattOrs (patchset #3 id:40001 of https://codereview.chromium.org/1611533002/ ) Reason for revert: buildbot failure in Chromium GPU on Android Debug (Nexus 6) [918/3714] LINK battor_agent ... obj/tools/battor_agent/libbattor_agent_lib.a(obj/tools/battor_agent/battor_agent_lib.battor_finder.o):battor_finder.cc:function battor::BattOrFinder::FindBattOr(): error: undefined reference to 'device::SerialDeviceEnumerator::Create()' Original issue's description: > tools/battor_agent: Adds a tool to find connected BattOrs > > This tool will also be used by the Chromium trace controller to find > any connected BattOrs. > > BUG=542837 > > Committed: https://crrev.com/22f5284d4b0e007cb59effaefa7dbd82717eca79 > Cr-Commit-Position: refs/heads/master@{#370985} TBR=zhenw@chromium.org,nednguyen@google.com,sky@chromium.org,charliea@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542837 Committed: https://crrev.com/07fbdfb23f9b20157776fe37fb504de60f960dc2 Cr-Commit-Position: refs/heads/master@{#370992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -87 lines) Patch
M tools/battor_agent/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/battor_agent/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/battor_agent/battor_agent.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/battor_agent/battor_agent_bin.cc View 4 chunks +4 lines, -20 lines 0 comments Download
D tools/battor_agent/battor_finder.h View 1 chunk +0 lines, -23 lines 0 comments Download
D tools/battor_agent/battor_finder.cc View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Scott Hess - ex-Googler
Created Revert of tools/battor_agent: Adds a tool to find connected BattOrs
4 years, 11 months ago (2016-01-22 17:52:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623563002/1
4 years, 11 months ago (2016-01-22 17:53:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 17:56:20 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 17:58:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07fbdfb23f9b20157776fe37fb504de60f960dc2
Cr-Commit-Position: refs/heads/master@{#370992}

Powered by Google App Engine
This is Rietveld 408576698