Add ContextProvider overrides to SynchronousCompositorFactory

content/renderer/pepper/pepper_platform_context_3d_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_platform_context_3d_impl.h"
 
 #include "base/bind.h"
 #include "content/common/gpu/client/context_provider_command_buffer.h"
 #include "content/common/gpu/client/gpu_channel_host.h"
 #include "content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h"
@@ skipping 107 matching lines @@
 
   return SetParentAndCreateBackingTextureIfNeeded();
 }
 
 bool PlatformContext3DImpl::SetParentAndCreateBackingTextureIfNeeded() {
   if (parent_context_provider_ &&
       !parent_context_provider_->DestroyedOnMainThread() &&
       parent_texture_id_)
     return true;
 
-  parent_context_provider_ =
-      RenderThreadImpl::current()->OffscreenContextProviderForMainThread();
+  parent_context_provider_ = static_cast<ContextProviderCommandBuffer*>(

[joth, 2013/06/02 19:08:55]

could we change parent_context_provider_  to be a base-class pointer rather than
cast here? AFAICT the public APIs are the same, so it's just a matter of who
else does this get passed to that also expects subclass pointer...

[boliu, 2013/06/03 18:51:24]

ContextProvider api is the almost same, just the CB provider returns a CB
context. But the public api on the context is not the same: GetImplementation
and GetCommandBufferProxy are not on the in-process context.

I think GetCommandBufferProxy in particular implies cross-process context, and
this has its own command_buffer_ of the same class. So unless we rewrite this
code to not hardcode this class, a cast is needed in this file somewhere.

No idea how hard this rewrite actually is.

+      RenderThreadImpl::current()->OffscreenContextProviderForMainThread()
+          .get());
   parent_texture_id_ = 0;
   if (!parent_context_provider_)
     return false;
 
   // Flush any remaining commands in the parent context to make sure the
   // texture id accounting stays consistent.
   gpu::gles2::GLES2Implementation* parent_gles2 =
       parent_context_provider_->Context3d()->GetImplementation();
   parent_gles2->helper()->CommandBufferHelper::Finish();
   parent_texture_id_ = parent_gles2->MakeTextureId();
@@ skipping 71 matching lines @@
 void PlatformContext3DImpl::OnConsoleMessage(const std::string& msg, int id) {
   DCHECK(command_buffer_);
 
   if (!console_message_callback_.is_null())
     console_message_callback_.Run(msg, id);
 }
 
 }  // namespace content
 
 #endif  // ENABLE_GPU