Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1623493002: Changed kWithInvalidationsRefreshDelayMs value to 24 hours (Closed)

Created:
4 years, 11 months ago by igorcov
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed kWithInvalidationsRefreshDelayMs value to 24 hours BUG=452716 Committed: https://crrev.com/df3e8ee64956ecfb320dfbd09d6d0092b54687fa Cr-Commit-Position: refs/heads/master@{#373208}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed the TODO comment for the task #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
igorcov
Please review changes. Only refresh interval with invalidations has changed. The default interval (kDefaultRefreshDelayMs) stays ...
4 years, 11 months ago (2016-01-22 15:41:38 UTC) #2
Andrew T Wilson (Slow)
lgtm
4 years, 11 months ago (2016-01-22 15:48:29 UTC) #3
bartfab (slow)
lgtm https://codereview.chromium.org/1623493002/diff/1/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc File components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc (right): https://codereview.chromium.org/1623493002/diff/1/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc#newcode46 components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc:46: // TODO(joaodasilva): increase this value once we're confident ...
4 years, 11 months ago (2016-01-25 15:14:35 UTC) #4
igorcov
On 2016/01/25 15:14:35, bartfab (slow) wrote: > lgtm > > https://codereview.chromium.org/1623493002/diff/1/components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc > File components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc > ...
4 years, 11 months ago (2016-01-25 18:20:35 UTC) #5
bartfab (slow)
lgtm
4 years, 11 months ago (2016-01-26 09:36:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623493002/20001
4 years, 11 months ago (2016-01-26 12:56:34 UTC) #9
commit-bot: I haz the power
The author igorcov@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 11 months ago (2016-01-26 12:56:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1623493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1623493002/20001
4 years, 10 months ago (2016-02-03 09:12:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-03 10:18:03 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 10:19:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df3e8ee64956ecfb320dfbd09d6d0092b54687fa
Cr-Commit-Position: refs/heads/master@{#373208}

Powered by Google App Engine
This is Rietveld 408576698