Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: src/IceInstARM32.cpp

Issue 1623433004: Add missing vcvt instructions to integrated ARM assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Fix nits. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstARM32.cpp
diff --git a/src/IceInstARM32.cpp b/src/IceInstARM32.cpp
index aaeed9cf8058d1d7ec6127f124248f263dbfa7b1..da7116605cc31b5ec9677ba921c13471b74aaa3a 100644
--- a/src/IceInstARM32.cpp
+++ b/src/IceInstARM32.cpp
@@ -1863,19 +1863,35 @@ void InstARM32Vcvt::emitIAS(const Cfg *Func) const {
case S2si:
Asm->vcvtis(getDest(), getSrc(0), getPredicate());
break;
+ case S2ui:
+ Asm->vcvtus(getDest(), getSrc(0), getPredicate());
+ break;
+ case Si2s:
+ Asm->vcvtsi(getDest(), getSrc(0), getPredicate());
+ break;
+ case Ui2s:
+ Asm->vcvtsu(getDest(), getSrc(0), getPredicate());
+ break;
+ case D2si:
+ Asm->vcvtid(getDest(), getSrc(0), getPredicate());
+ break;
+ case D2ui:
+ Asm->vcvtud(getDest(), getSrc(0), getPredicate());
+ break;
+ case Si2d:
+ Asm->vcvtdi(getDest(), getSrc(0), getPredicate());
+ break;
+ case Ui2d:
+ Asm->vcvtdu(getDest(), getSrc(0), getPredicate());
+ break;
case S2d:
Asm->vcvtds(getDest(), getSrc(0), getPredicate());
break;
case D2s:
Asm->vcvtsd(getDest(), getSrc(0), getPredicate());
break;
- default:
- // TODO(kschimpf): Fill in other variants.
- Asm->setNeedsTextFixup();
- break;
}
- if (Asm->needsTextFixup())
- emitUsingTextFixup(Func);
+ assert(!Asm->needsTextFixup());
}
void InstARM32Vcvt::dump(const Cfg *Func) const {

Powered by Google App Engine
This is Rietveld 408576698