Issue 16234: Reverting my landing (of a patch by external contributer)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16234: Reverting my landing (of a patch by external contributer).... (Closed)

Created:
12 years ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting my landing (of a patch by external contributer). I jumped the gun, Peter raised additional issues after we both LGTM'ed (and I didn't notice those emails). TBR=pkasting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7412

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/browser.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

12 years ago (2008-12-23 17:57:36 UTC) #2

Shrug, it would have been OK to leave this landed and just do a followup cleanup
patch, the issues were minor.  But whatever.

Expand Messages | Collapse Messages