Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 162333002: Cast: Rtcp and RtcpSender don't take event logs (Closed)

Created:
6 years, 10 months ago by Alpha Left Google
Modified:
6 years, 10 months ago
Reviewers:
mikhal1
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Cast: Rtcp and RtcpSender don't take event logs This is the first change to allow RtcpSender to send redundant events. Rtcp and RtcpSender interface used to accept receiver events logs. They are now changed to accept ReceiverRtcpEventSubscriber. This allows RtcpSender to fetch event logs from the subscriber directly. No functional change other than passing event subscriber instead of event logs. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251147

Patch Set 1 #

Patch Set 2 : cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -85 lines) Patch
M media/cast/audio_receiver/audio_receiver.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/cast/rtcp/rtcp.h View 2 chunks +5 lines, -7 lines 0 comments Download
media/cast/rtcp/rtcp.cc View 3 chunks +6 lines, -5 lines 0 comments Download
media/cast/rtcp/rtcp_sender.h View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M media/cast/rtcp/rtcp_sender_unittest.cc View 1 8 chunks +45 lines, -60 lines 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Alpha Left Google
6 years, 10 months ago (2014-02-13 00:14:44 UTC) #1
mikhal1
On 2014/02/13 00:14:44, Alpha wrote: lgtm
6 years, 10 months ago (2014-02-13 00:38:05 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 10 months ago (2014-02-13 02:45:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/162333002/1
6 years, 10 months ago (2014-02-13 02:47:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 04:23:28 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=75827
6 years, 10 months ago (2014-02-13 04:23:30 UTC) #6
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 10 months ago (2014-02-13 07:13:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/162333002/1
6 years, 10 months ago (2014-02-13 07:13:20 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 09:14:16 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=75867
6 years, 10 months ago (2014-02-13 09:14:17 UTC) #10
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 10 months ago (2014-02-13 18:03:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/162333002/1
6 years, 10 months ago (2014-02-13 18:04:40 UTC) #12
Alpha Left Google
The CQ bit was unchecked by hclam@chromium.org
6 years, 10 months ago (2014-02-13 18:05:26 UTC) #13
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 10 months ago (2014-02-13 18:28:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/162333002/500001
6 years, 10 months ago (2014-02-13 18:28:53 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/162333002/500001
6 years, 10 months ago (2014-02-13 19:57:28 UTC) #16
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 22:06:30 UTC) #17
Message was sent while issue was closed.
Change committed as 251147

Powered by Google App Engine
This is Rietveld 408576698