Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h

Issue 16232016: [NaCl SDK] nacl_io: big refactor to return error value (errno). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h
diff --git a/native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h b/native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h
index 58b4d13d7ec1920d0985500ab8490a76fbc194b2..7398328778966e0087b6f1966d3a640a46382301 100644
--- a/native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h
+++ b/native_client_sdk/src/libraries/nacl_io/mount_node_html5fs.h
@@ -15,20 +15,26 @@ class MountNodeHtml5Fs : public MountNode {
// Normal OS operations on a node (file), can be called by the kernel
// directly so it must lock and unlock appropriately. These functions
// must not be called by the mount.
- virtual int FSync();
- virtual int GetDents(size_t offs, struct dirent* pdir, size_t count);
- virtual int GetStat(struct stat* stat);
- virtual int Read(size_t offs, void* buf, size_t count);
- virtual int FTruncate(off_t size);
- virtual int Write(size_t offs, const void* buf, size_t count);
-
- virtual size_t GetSize();
+ virtual Error FSync();
+ virtual Error GetDents(size_t offs,
+ struct dirent* pdir,
+ size_t count,
+ int* out_bytes);
+ virtual Error GetStat(struct stat* stat);
+ virtual Error Read(size_t offs, void* buf, size_t count, int* out_bytes);
+ virtual Error FTruncate(off_t size);
+ virtual Error Write(size_t offs,
+ const void* buf,
+ size_t count,
+ int* out_bytes);
+
+ virtual Error GetSize(size_t *out_size);
protected:
MountNodeHtml5Fs(Mount* mount, PP_Resource fileref);
// Init with standard open flags
- virtual bool Init(int o_mode);
+ virtual Error Init(int o_mode);
virtual void Destroy();
private:

Powered by Google App Engine
This is Rietveld 408576698