[NaCl SDK] nacl_io: big refactor to return error value (errno).

native_client_sdk/src/libraries/nacl_io_test/kernel_proxy_test.cc

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <errno.h>
 #include <fcntl.h>
 #include <pthread.h>
 #include <sys/stat.h>
 
 #include <map>
 #include <string>
 
 #include "nacl_io/kernel_handle.h"
 #include "nacl_io/kernel_intercept.h"
 #include "nacl_io/kernel_proxy.h"
 #include "nacl_io/mount.h"
 #include "nacl_io/mount_mem.h"
 #include "nacl_io/osmman.h"
 #include "nacl_io/path.h"
 
 #include "gtest/gtest.h"
 
-
 class KernelProxyTest : public ::testing::Test {
  public:
-  KernelProxyTest()
-      : kp_(new KernelProxy) {
+  KernelProxyTest() : kp_(new KernelProxy) {
     ki_init(kp_);
     // Unmount the passthrough FS and mount a memfs.
     EXPECT_EQ(0, kp_->umount("/"));
     EXPECT_EQ(0, kp_->mount("", "/", "memfs", 0, NULL));
   }
 
   ~KernelProxyTest() {
     ki_uninit();
     delete kp_;
   }
 
  private:
   KernelProxy* kp_;
 };
 
-
 TEST_F(KernelProxyTest, WorkingDirectory) {
   char text[1024];
 
   text[0] = 0;
   ki_getcwd(text, sizeof(text));
   EXPECT_STREQ("/", text);
 
   char* alloc = ki_getwd(NULL);
-  EXPECT_EQ((char *) NULL, alloc);
+  EXPECT_EQ((char*)NULL, alloc);
   EXPECT_EQ(EFAULT, errno);
 
   text[0] = 0;
   alloc = ki_getwd(text);
   EXPECT_STREQ("/", alloc);
 
   EXPECT_EQ(-1, ki_chdir("/foo"));
   EXPECT_EQ(ENOENT, errno);
 
   EXPECT_EQ(0, ki_chdir("/"));
@@ skipping 42 matching lines @@
 
   // Write hello and world to same node with different descriptors
   // so that we overwrite each other
   EXPECT_EQ(5, ki_write(fd2, "WORLD", 5));
   EXPECT_EQ(5, ki_write(fd1, "HELLO", 5));
 
   fd3 = ki_open("/foo/bar", O_WRONLY);
   EXPECT_NE(-1, fd3);
 
   len = ki_read(fd3, text, sizeof(text));
-  if (len > -0) text[len] = 0;
+  if (len > -0)

[noelallen1, 2013/06/07 21:48:43]

-0?

[binji, 2013/06/07 23:23:11]

Done.

+    text[len] = 0;
   EXPECT_EQ(5, len);
   EXPECT_STREQ("HELLO", text);
   EXPECT_EQ(0, ki_close(fd1));
   EXPECT_EQ(0, ki_close(fd2));
 
   fd1 = ki_open("/foo/bar", O_WRONLY | O_APPEND);
   EXPECT_NE(-1, fd1);
   EXPECT_EQ(5, ki_write(fd1, "WORLD", 5));
 
   len = ki_read(fd3, text, sizeof(text));
-  if (len >= 0) text[len] = 0;
+  if (len >= 0)
+    text[len] = 0;
 
   EXPECT_EQ(5, len);
   EXPECT_STREQ("WORLD", text);
 
   fd2 = ki_open("/foo/bar", O_RDONLY);
   EXPECT_NE(-1, fd2);
   len = ki_read(fd2, text, sizeof(text));
-  if (len > 0) text[len] = 0;
+  if (len > 0)
+    text[len] = 0;
   EXPECT_EQ(10, len);
   EXPECT_STREQ("HELLOWORLD", text);
 }
 
 TEST_F(KernelProxyTest, MemMountLseek) {
   int fd = ki_open("/foo", O_CREAT | O_RDWR);
   EXPECT_EQ(9, ki_write(fd, "Some text", 9));
 
   EXPECT_EQ(9, ki_lseek(fd, 0, SEEK_CUR));
   EXPECT_EQ(9, ki_lseek(fd, 0, SEEK_END));
@@ skipping 44 matching lines @@
   EXPECT_EQ(4, ki_write(dup_fd, "more", 4));
 
   EXPECT_EQ(0, ki_close(dup2_fd));
   // fd, new_fd -> "/bar"
   // dup_fd -> "/foo"
 
   EXPECT_EQ(dup_fd, ki_dup2(fd, dup_fd));
   // fd, new_fd, dup_fd -> "/bar"
 }
 
-
 StringMap_t g_StringMap;
 
 class MountMockInit : public MountMem {
  public:
-  virtual bool Init(int dev, StringMap_t& args, PepperInterface* ppapi) {
+  virtual Error Init(int dev, StringMap_t& args, PepperInterface* ppapi) {
     g_StringMap = args;
     if (args.find("false") != args.end())
-      return false;
-    return true;
-  };
+      return EINVAL;
+    return 0;
+  }
+  ;
 };
 
 class KernelProxyMountMock : public KernelProxy {
   virtual void Init(PepperInterface* ppapi) {
     KernelProxy::Init(NULL);
     factories_["initfs"] = MountMockInit::Create<MountMockInit>;
   }
 };
 
 class KernelProxyMountTest : public ::testing::Test {
  public:
-  KernelProxyMountTest()
-      : kp_(new KernelProxyMountMock) {
-    ki_init(kp_);
-  }
+  KernelProxyMountTest() : kp_(new KernelProxyMountMock) { ki_init(kp_); }
 
   ~KernelProxyMountTest() {
     ki_uninit();
     delete kp_;
   }
 
  private:
   KernelProxy* kp_;
 };
 
 TEST_F(KernelProxyMountTest, MountInit) {
   int res1 = ki_mount("/", "/mnt1", "initfs", 0, "false,foo=bar");
 
   EXPECT_EQ("bar", g_StringMap["foo"]);
   EXPECT_EQ(-1, res1);
   EXPECT_EQ(EINVAL, errno);
 
   int res2 = ki_mount("/", "/mnt2", "initfs", 0, "true,bar=foo,x=y");
   EXPECT_NE(-1, res2);
   EXPECT_EQ("y", g_StringMap["x"]);
 }
 
-
 namespace {
 
 int g_MMapCount = 0;
 
 class MountNodeMockMMap : public MountNode {
  public:
-  MountNodeMockMMap(Mount* mount)
-      : MountNode(mount),
-        node_mmap_count_(0) {
-    Init(0);
+  MountNodeMockMMap(Mount* mount) : MountNode(mount), node_mmap_count_(0) {
+    EXPECT_EQ(0, Init(0));
   }
 
-  virtual void* MMap(void* addr, size_t length, int prot, int flags,
-                     size_t offset) {
+  virtual Error MMap(void* addr,
+                     size_t length,
+                     int prot,
+                     int flags,
+                     size_t offset,
+                     void** out_addr) {
     node_mmap_count_++;
     switch (g_MMapCount++) {
-      case 0: return reinterpret_cast<void*>(0x1000);
-      case 1: return reinterpret_cast<void*>(0x2000);
-      case 2: return reinterpret_cast<void*>(0x3000);
-      default: return MAP_FAILED;
+      case 0:
+        *out_addr = reinterpret_cast<void*>(0x1000);
+        break;
+      case 1:
+        *out_addr = reinterpret_cast<void*>(0x2000);
+        break;
+      case 2:
+        *out_addr = reinterpret_cast<void*>(0x3000);
+        break;
+      default:
+        return EPERM;
     }
+
+    return 0;
   }
 
  private:
   int node_mmap_count_;
 };
 
 class MountMockMMap : public Mount {
  public:
-  virtual MountNode* Open(const Path& path, int mode) {
+  virtual Error Open(const Path& path, int mode, MountNode** out_node) {
     MountNodeMockMMap* node = new MountNodeMockMMap(this);
-    return node;
+    *out_node = node;
+    return 0;
   }
 
-  virtual MountNode* OpenResource(const Path& path) { return NULL; }
-  virtual int Unlink(const Path& path) { return -1; }
-  virtual int Mkdir(const Path& path, int permissions) { return -1; }
-  virtual int Rmdir(const Path& path) { return -1; }
-  virtual int Remove(const Path& path) { return -1; }
+  virtual Error OpenResource(const Path& path, MountNode** out_node) {
+    *out_node = NULL;
+    return ENOSYS;
+  }
+  virtual Error Unlink(const Path& path) { return ENOSYS; }
+  virtual Error Mkdir(const Path& path, int permissions) { return ENOSYS; }
+  virtual Error Rmdir(const Path& path) { return ENOSYS; }
+  virtual Error Remove(const Path& path) { return ENOSYS; }
 };
 
 class KernelProxyMockMMap : public KernelProxy {
   virtual void Init(PepperInterface* ppapi) {
     KernelProxy::Init(NULL);
     factories_["mmapfs"] = MountMockInit::Create<MountMockMMap>;
   }
 };
 
 class KernelProxyMMapTest : public ::testing::Test {
  public:
-  KernelProxyMMapTest()
-      : kp_(new KernelProxyMockMMap) {
-    ki_init(kp_);
-  }
+  KernelProxyMMapTest() : kp_(new KernelProxyMockMMap) { ki_init(kp_); }
 
   ~KernelProxyMMapTest() {
     ki_uninit();
     delete kp_;
   }
 
  private:
   KernelProxy* kp_;
 };
 
@@ skipping 17 matching lines @@
   EXPECT_EQ(reinterpret_cast<void*>(0x3000), addr3);
   EXPECT_EQ(3, g_MMapCount);
 
   ki_close(fd);
 
   // We no longer track mmap'd regions, so munmap is a no-op.
   EXPECT_EQ(0, ki_munmap(reinterpret_cast<void*>(0x1000), 0x2800));
   // We don't track regions, so the mmap count hasn't changed.
   EXPECT_EQ(3, g_MMapCount);
 }